Skip to content

Commit 741a07b

Browse files
committed
bench: increase iteration for criterion benchmarks
Set a fixed runtime of 10 seconds instead of fixed sample count, to try and increase stability because the benchmarks always fail spuriously. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
1 parent 331ffec commit 741a07b

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/vmm/benches/block_request.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ pub fn block_request_benchmark(c: &mut Criterion) {
3636

3737
criterion_group! {
3838
name = block_request_benches;
39-
config = Criterion::default().sample_size(1000).noise_threshold(0.05);
39+
config = Criterion::default().noise_threshold(0.05).measurement_time(std::time::Duration::from_secs(10)).sample_size(10000);
4040
targets = block_request_benchmark
4141
}
4242

src/vmm/benches/cpu_templates.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ pub fn cpu_template_benchmark(c: &mut Criterion) {
4444

4545
criterion_group! {
4646
name = cpu_template_benches;
47-
config = Criterion::default().sample_size(200).noise_threshold(0.05);
47+
config = Criterion::default().noise_threshold(0.05).measurement_time(std::time::Duration::from_secs(10)).sample_size(10000);
4848
targets = cpu_template_benchmark
4949
}
5050

src/vmm/benches/memory_access.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ pub fn bench_2m_page_fault(c: &mut Criterion) {
5959

6060
criterion_group! {
6161
name = memory_access_benches;
62-
config = Criterion::default().noise_threshold(0.05);
62+
config = Criterion::default().noise_threshold(0.05).measurement_time(std::time::Duration::from_secs(10)).sample_size(10000);
6363
targets = bench_4k_page_fault, bench_2m_page_fault
6464
}
6565

src/vmm/benches/queue.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ pub fn queue_benchmark(c: &mut Criterion) {
108108

109109
criterion_group! {
110110
name = queue_benches;
111-
config = Criterion::default().sample_size(1000).noise_threshold(0.15);
111+
config = Criterion::default().noise_threshold(0.15).measurement_time(std::time::Duration::from_secs(10)).sample_size(10000);
112112
targets = queue_benchmark
113113
}
114114

0 commit comments

Comments
 (0)