refactor: specify explicit arguments for ab_test.py

Add arguments names for binary paths for ab_test.py

Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>

Author: ShadowCurse

.buildkite/pipeline_perf.py

@@ -134,7 +134,7 @@
     test_script_opts = ""
     if REVISION_A:
         devtool_opts += " --ab"
-        test_script_opts = f'{ab_opts} run build/{REVISION_A}/ build/{REVISION_B} --pytest-opts "{test_selector}"'
+        test_script_opts = f'{ab_opts} run --binaries_a build/{REVISION_A}/ --binaries_b build/{REVISION_B} --pytest-opts "{test_selector}"'
     else:
         # Passing `-m ''` below instructs pytest to collect tests regardless of
         # their markers (e.g. it will collect both tests marked as nonci, and

tests/README.md

@@ -184,7 +184,7 @@ function to [`.buildkite/pipeline_perf.py`](../.buildkite/pipeline_perf.py). To
 manually run an A/B-Test, use
 
 ```sh
-tools/devtool -y test --ab [optional arguments to ab_test.py] run <dir A> <dir B> --pytest-opts <test specification>
+tools/devtool -y test --ab [optional arguments to ab_test.py] run --binaries_a <dir A> --binaries_b <dir B> --pytest-opts <test specification>
 ```
 
 Here, _dir A_ and _dir B_ are directories containing firecracker and jailer

tools/ab_test.py

@@ -422,14 +422,16 @@ def ab_performance_test(
         help="Run an specific test of our test suite as an A/B-test across two specified commits",
     )
     run_parser.add_argument(
-        "a_revision",
+        "--binaries-a",
         help="Directory containing firecracker and jailer binaries to be considered the performance baseline",
         type=Path,
+        required=True,
     )
     run_parser.add_argument(
-        "b_revision",
-        help="Directory containing firecracker and jailer binaries whose performance we want to compare against the results from a_revision",
+        "--binaries-b",
+        help="Directory containing firecracker and jailer binaries whose performance we want to compare against the results from binaries-a",
         type=Path,
+        required=True,
     )
     run_parser.add_argument(
         "--pytest-opts",
@@ -472,8 +474,8 @@ def ab_performance_test(
 
     if args.command == "run":
         ab_performance_test(
-            args.a_revision,
-            args.b_revision,
+            args.binaries_a,
+            args.binaries_b,
             args.pytest_opts,
             args.significance,
             args.absolute_strength,