Add a DriveOpt func for configuring CacheType #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzys
reviewed
Apr 27, 2022
drives.go
Outdated
| @@ -103,3 +103,15 @@ func WithRateLimiter(limiter models.RateLimiter) DriveOpt { | |||
| d.RateLimiter = &limiter | |||
| } | |||
| } | |||
|
|
|||
| // WithCacheType sets the cache strategy for the block device | |||
| func WithCacheType(cache_type string) DriveOpt { | |||
There was a problem hiding this comment.
Generally variables in Go are camelCase.
There was a problem hiding this comment.
Ack. Will change to camelCase
kzys
suggested changes
Apr 27, 2022
drives.go
Outdated
Comment on lines
109
to
113
| if cache_type == "" { | ||
| return func(_ *models.Drive) { | ||
| // no-op | ||
| } | ||
| } |
There was a problem hiding this comment.
Seems we don't do this kind of check in most of helpers here. Do you have specific reasons to do here?
One concern I have is that if someone pass "" unintentionally, it would be ignored. Should we pass "" as is and let Firecracker error out?
There was a problem hiding this comment.
I do see your point about letting Firecracker handle everything as is. I added this input validation since I might have to use this later from FC-CD and pass "". Though I can add a helper in FC-CD to do just that.
Will remove this check from here.
Signed-off-by: Swagat Bora <sbora@amazon.com>
swagatbora90
force-pushed
the
add-cache-type-support
branch
from
d394d1a to
96eca0b
Compare
kzys
reviewed
Apr 27, 2022
kzys
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding a optional function to set "CacheType" of a Drive. "CacheType" is an optional field that we can now set for models.Drive and supports 2 values: "Unsafe" and "Writeback".
The aim is to make use of this function in firecracker-containerd if client requests CacheType to be set for the root drive or the other mounted drives
Testing:
make test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.