Removes JailerEnable and changes JailerCfg to be a pointer #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelkarp
reviewed
Aug 5, 2019
machine.go
Outdated
| @@ -98,6 +98,33 @@ type Config struct { | |||
| JailerCfg JailerConfig | |||
| } | |||
|
|
|||
| // WithJailerConfig will set the given JailerConfig to the JailerCfg field. In | |||
| // addition this will also set EnableJailer to true | |||
There was a problem hiding this comment.
Do we strictly need to have the EnableJailer field or can we enable the jailer when JailerCfg != nil?
There was a problem hiding this comment.
Yea, that is an option, using nil as an indicator. I wanted to prevent doing that since whenever you want to grab values from the jailer config, you'd need to nil check. But I am okay with using nil as a check if we think that is a better experience.
There was a problem hiding this comment.
I agree it seems simpler to just have our code do nil checks internally and enable the jailer when JailerCfg is not nil. I think I'd be confused as a user if I saw there was EnableJailer, JailerCfg and WithJailerConfig.
This fix allows for a more intuitive design in letting users enable the jailer. Signed-off-by: xibz <impactbchang@gmail.com>
samuelkarp
approved these changes
Aug 6, 2019
sipsma
approved these changes
Aug 6, 2019
xibz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows for a more intuitive design in letting users enable the
jailer.
Signed-off-by: xibz impactbchang@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.