This repository was archived by the owner on Aug 13, 2018. It is now read-only.
Toggle Protocols #58
Merged
Toggle Protocols #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,7 +82,8 @@ var FrameList = React.createClass({ | |||
| key: "frame-" + frame.id, | |||
| frame: frame, | |||
| selection: this.props.selection, | |||
| dispatch: this.props.dispatch | |||
| dispatch: this.props.dispatch, | |||
| config: this.props.dispatch | |||
There was a problem hiding this comment.
Should be: config: this.props.config
Honza
There was a problem hiding this comment.
Yes, you're right. Thanks
|
Nice job here! I made a few comments, please fix and I'll merge it into the master and release a new WSM version. Honza |
|
Thanks for the review. I'll fix your comments later today. |
|
All righty, I have now implemented the changes you requested |
|
Awesome, thanks! Honza |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds a new feature - the ability to selectively enable or disable support for websocket protocols. This is added to the extension preferences window using the
simple-prefsAPI.Why
There are a few downsides to having all protocols enabled at all times.
subscribe?..., are parsed by the parser as MQTT, which is not what I expect it to doHow
I added a new store and changed redux to be populated with the prefs at load. I also use the
onPrefChangedhook to update the store on demand. Changing a setting is not retroactive, i.e. it will not change any already parsed frames, only future frames. I do not currently see this as an issue worth the complexity to fix.