Skip to content

refactor(fcm): check for permission before posting notification #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

refactor(fcm): check for permission before posting notification #2674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions ...src/main/java/com/google/samples/quickstart/functions/java/FunctionsMessagingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
package com.google.samples.quickstart.functions.java;

import android.Manifest;
import android.app.Notification;
import android.app.NotificationChannel;
import android.app.NotificationManager;
import android.content.pm.PackageManager;
import android.os.Build;

import androidx.core.app.NotificationCompat;
import androidx.core.app.NotificationManagerCompat;
import androidx.core.content.ContextCompat;

import android.util.Log;

import com.google.firebase.messaging.FirebaseMessagingService;
Expand Down Expand Up @@ -39,13 +44,17 @@ public void onMessageReceived(RemoteMessage remoteMessage) {
// Check if message contains a data payload.
if (remoteMessage.getData().size() > 0) {
Log.d(TAG, "Message data payload: " + remoteMessage.getData());
NotificationManagerCompat manager = NotificationManagerCompat.from(this);
Notification notification = new NotificationCompat.Builder(this, "Messages")
.setContentText(remoteMessage.getData().get("text"))
.setContentTitle("New message")
.setSmallIcon(R.drawable.ic_stat_notification)
.build();
manager.notify(0, notification);
// Check if permission to post notifications has been granted
if (ContextCompat.checkSelfPermission(this,
Manifest.permission.POST_NOTIFICATIONS) == PackageManager.PERMISSION_GRANTED) {
NotificationManagerCompat manager = NotificationManagerCompat.from(this);
Notification notification = new NotificationCompat.Builder(this, "Messages")
.setContentText(remoteMessage.getData().get("text"))
.setContentTitle("New message")
.setSmallIcon(R.drawable.ic_stat_notification)
.build();
manager.notify(0, notification);
}
}
}
}
22 changes: 15 additions & 7 deletions ...src/main/java/com/google/samples/quickstart/functions/kotlin/FunctionsMessagingService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
package com.google.samples.quickstart.functions.kotlin

import android.Manifest
import android.app.NotificationChannel
import android.app.NotificationManager
import android.content.pm.PackageManager
import android.os.Build
import android.util.Log
import androidx.core.app.NotificationCompat
import androidx.core.app.NotificationManagerCompat
import androidx.core.content.ContextCompat
import com.google.firebase.messaging.FirebaseMessagingService
import com.google.firebase.messaging.RemoteMessage
import com.google.samples.quickstart.functions.R
Expand All @@ -32,13 +35,18 @@ class FunctionsMessagingService : FirebaseMessagingService() {
// Check if message contains a data payload.
if (remoteMessage.data.isNotEmpty()) {
Log.d(TAG, "Message data payload: " + remoteMessage.data)
val manager = NotificationManagerCompat.from(this)
val notification = NotificationCompat.Builder(this, "Messages")
.setContentText(remoteMessage.data["text"])
.setContentTitle("New message")
.setSmallIcon(R.drawable.ic_stat_notification)
.build()
manager.notify(0, notification)
// Check if permission to post notifications has been granted
if (ContextCompat.checkSelfPermission(this, Manifest.permission.POST_NOTIFICATIONS) ==
PackageManager.PERMISSION_GRANTED
) {
val manager = NotificationManagerCompat.from(this)
val notification = NotificationCompat.Builder(this, "Messages")
.setContentText(remoteMessage.data["text"])
.setContentTitle("New message")
.setSmallIcon(R.drawable.ic_stat_notification)
.build()
manager.notify(0, notification)
}
}
}

Expand Down
Loading