chore: Prepare towards PHP8.4 compatibility #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolli42
approved these changes
Jul 29, 2024
This was referenced Aug 5, 2024
bshaffer
approved these changes
Aug 7, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request contains three commits:
chore: fix latest php-cs-fixer findings
This ensures clean cgl state using the current php-cs-fixer version and ruleset.
chore: Mitigate PHP8.4 deprecation warnings (#570)
This change replaces implicitly nullable method arguments by making them explicitly nullable to mitigate PHP8.4 deprecation warnings.
chore: Enable php-cs-fixer rules to avoid implicitly nullable method arguments
This change enables two rules in the php-cs-fixer ruleset to guard against future implicitly method arguments and ensures to use the
?nullable operator for nullable methods and properties.Resolves: #570