Skip to content

Changed $token to $payload #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Changed $token to $payload #229

merged 1 commit into from
Nov 12, 2019

Conversation

glaand
Copy link

@glaand glaand commented Oct 19, 2018

Changed $token to $payload, at first sight it is not clearly why "$token" is names as $token since this "$token" represents the payload of the JWT.

Changed $token to $payload, at first sight it is not clearly why "$token" is names as $token since this "$token" represents the payload of the JWT.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@glaand
Copy link
Author

glaand commented Oct 19, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@bshaffer bshaffer merged commit bc324de into firebase:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants