get everything to compile

Author: morganchen12

functions/.mocharc.json

@@ -0,0 +1,4 @@
+{
+    "loader": "ts-node/esm",
+    "extensions": ["ts"]
+}

functions/src/config.ts

@@ -244,11 +244,22 @@ export class BotConfig {
 
     // Iterate through issue labels, see if one of the existing ones works
     // TODO(samstern): Deal with needs_triage separately
-    const issueLabelNames: string[] = issue.labels.map((label) => {
-      return label.name;
-    });
+    const issueLabelNames: (string | undefined)[] = issue.labels
+      .filter((label) => {
+        return label !== undefined;
+      })
+      .map((label) => {
+        if (typeof label === "string") {
+          return label;
+        }
+        return label.name;
+      });
 
     for (const key of issueLabelNames) {
+      if (!key) {
+        // After typescript 5.5 this check can be removed?
+        continue;
+      }
       const label_mapping = this.getRepoLabelConfig(org, name, key);
       if (label_mapping) {
         return {
@@ -274,7 +285,7 @@ export class BotConfig {
       const regex = new RegExp(labelInfo.regex);
 
       // If the regex matches, choose the label and email then break out
-      if (regex.test(issue.body)) {
+      if (regex.test(issue.body ?? "")) {
         log.debug("Matched label: " + label, JSON.stringify(labelInfo));
         return {
           label,

functions/src/cron.ts

@@ -173,7 +173,12 @@ export class CronHandler {
     const actions: types.Action[] = [];
 
     const number = issue.number;
-    const labelNames = issue.labels.map((label) => label.name);
+    const labelNames = issue.labels.map((label) => {
+      if (typeof label === "string") {
+        return label;
+      }
+      return label.name;
+    });
 
     const stateNeedsInfo = labelNames.includes(issueConfig.label_needs_info);
     const stateStale = labelNames.includes(issueConfig.label_stale);
@@ -214,7 +219,7 @@ export class CronHandler {
 
     // When the issue was marked stale, the bot will have left a comment with certain metadata
     const markStaleComment = comments.find((comment) => {
-      return comment.body.includes(EVT_MARK_STALE);
+      return comment.body?.includes(EVT_MARK_STALE);
     });
 
     if (stateStale && !markStaleComment) {
@@ -253,7 +258,7 @@ export class CronHandler {
         org,
         name,
         number,
-        this.getCloseComment(issue.user.login),
+        this.getCloseComment(issue.user?.login ?? "ghost"),
         false,
         `Comment after closing issue for being stale (comment at ${util.createdDate(
           markStaleComment!,
@@ -302,7 +307,7 @@ export class CronHandler {
         name,
         number,
         this.getMarkStaleComment(
-          issue.user.login,
+          issue.user?.login ?? "ghost",
           issueConfig.needs_info_days,
           issueConfig.stale_days,
         ),

functions/src/github.ts

@@ -109,9 +109,13 @@ export class GitHubClient {
         repo: name,
         path: file,
       })
-      .then(function (res) {
-        // Content is encoded as base64, we need to decode it
-        return new Buffer(res.data.content, "base64").toString();
+      .then((res) => {
+        if ("content" in res.data) {
+          // Content is encoded as base64, we need to decode it
+          return Buffer.from(res.data.content, "base64").toString();
+        }
+        log.warn(`Tried to get file content from non-file path ${file}`);
+        return "";
       });
   }
 

functions/src/index.ts

@@ -25,9 +25,9 @@ import * as config from "./config";
 import * as types from "./types";
 import * as util from "./util";
 import * as log from "./log";
+import * as pubsub from "./pubsub";
 
 import { database } from "./database";
-import { sendPubSub } from "./pubsub";
 import {
   createEventsTable,
   createIssuesTable,
@@ -89,9 +89,9 @@ const pr_handler = new pullrequests.PullRequestHandler(bot_config);
 // Handler for Cron jobs
 const cron_handler = new cron.CronHandler(gh_client, bot_config);
 
-export const eventWebhook = functions
-  .runWith(util.FUNCTION_OPTS)
-  .https.onRequest(async (request, response) => {
+export const eventWebhook = functions.https.onRequest(
+  util.FUNCTION_OPTS,
+  async (request, response) => {
     const type = request.get("X-GitHub-Event");
     if (!type) {
       response.status(400).send("Must include type!");
@@ -117,14 +117,15 @@ export const eventWebhook = functions
     response.json({
       status: "ok",
     });
-  });
+  },
+);
 
 /**
  * Function that responds to GitHub events (HTTP webhook).
  */
-export const githubWebhook = functions
-  .runWith(util.FUNCTION_OPTS)
-  .https.onRequest(async (request, response) => {
+export const githubWebhook = functions.https.onRequest(
+  util.FUNCTION_OPTS,
+  async (request, response) => {
     // Get event and action;
     const event = request.get("X-GitHub-Event");
     const action = request.body.action;
@@ -272,29 +273,30 @@ export const githubWebhook = functions
       .catch((e) => {
         response.send("Error!");
       });
-  });
+  },
+);
 
 /**
- * Function that responds to pubsub events sent via an AppEngine crojob.
+ * Function that responds to pubsub events sent via an AppEngine cronjob.
  */
-export const botCleanup = functions
-  .runWith(util.FUNCTION_OPTS)
-  .pubsub.schedule("every day 18:00")
-  .onRun(async () => {
+export const botCleanup = functions.scheduler.onSchedule(
+  "every day 18:00",
+  async () => {
     console.log("The cleanup job is running!");
     const repos = bot_config.getAllRepos();
     for (const repo of repos) {
-      await sendPubSub("bot-cleanup-repo", { org: repo.org, repo: repo.name });
+      await pubsub.sendPubSub("bot-cleanup-repo", {
+        org: repo.org,
+        repo: repo.name,
+      });
     }
+  },
+);
 
-    return true;
-  });
-
-export const botCleanupRepo = functions
-  .runWith(util.FUNCTION_OPTS)
-  .pubsub.topic("bot-cleanup-repo")
-  .onPublish(async (event, ctx) => {
-    const data = event.json;
+export const botCleanupRepo = functions.pubsub.onMessagePublished(
+  "bot-cleanup-repo",
+  async (event) => {
+    const data = event.data.message.json;
 
     const org = data.org;
     const repo = data.repo;
@@ -327,7 +329,8 @@ export const botCleanupRepo = functions
     await safeExecuteActions(actions);
 
     return true;
-  });
+  },
+);
 
 async function safeExecuteActions(actions: types.Action[]): Promise<void> {
   for (const action of actions) {
@@ -443,10 +446,9 @@ async function executeAction(action: types.Action): Promise<any> {
 /**
  * Manually run this function to create tables.
  */
-export const ensureBigquery = functions
-  .runWith(util.FUNCTION_OPTS)
-  .pubsub.topic("ensure-bigquery")
-  .onPublish(async () => {
+export const ensureBigquery = functions.pubsub.onMessagePublished(
+  "ensure-bigquery",
+  async () => {
     const repos = bot_config.getAllRepos();
     const orgs = new Set<string>(repos.map((r) => r.org));
 
@@ -463,4 +465,5 @@ export const ensureBigquery = functions
         await createEventsTable(org);
       }
     }
-  });
+  },
+);

functions/src/issues.ts

@@ -137,7 +137,9 @@ export class IssueHandler {
       case IssueAction.REOPENED:
         return this.onIssueStatusChanged(repo, issue, IssueStatus.OPEN);
       case IssueAction.LABELED:
-        return this.onIssueLabeled(repo, issue, event.label.name);
+        if (event.label.name) {
+          return this.onIssueLabeled(repo, issue, event.label.name);
+        }
       case IssueAction.UNASSIGNED:
       /* falls through */
       case IssueAction.UNLABELED:
@@ -218,18 +220,16 @@ export class IssueHandler {
     }
 
     // If the issue is filed by a collaborator, we stop here.
-    const isCollaborator = await snapshot.userIsCollaborator(
-      org,
-      name,
-      issue.user.login,
-    );
+    const isCollaborator = issue.user
+      ? await snapshot.userIsCollaborator(org, name, issue.user.login)
+      : false;
     if (isCollaborator) {
       actions.push(
         new types.GitHubNoOpAction(
           org,
           name,
           issue.number,
-          `No further action taken on this issue because it was filed by repo collaborator: ${issue.user.login}`,
+          `No further action taken on this issue because it was filed by repo collaborator: ${issue.user!.login}`,
         ),
       );
 
@@ -244,7 +244,6 @@ export class IssueHandler {
     // Filter spam from b/378634578. This can be removed in the future.
     const spamWords = [
       "pemain",
-      "wallet wallet", // seems to be in most crypto issues
       "minecraft",
       "paybis",
       "blockchain",
@@ -256,7 +255,6 @@ export class IssueHandler {
       "moonpay",
       "coinmama",
       "daftar",
-      ["wallet", "support"],
     ];
     const issueContent = ` ${issue.title} ${issue.body || ""} `.toLowerCase();
     // Scope spam filtering to affected repos only.
@@ -277,12 +275,12 @@ export class IssueHandler {
       });
 
     if (isSpam) {
-      // Discard other actions, wipe and lock the issue, and block
-      // the offending user.
+      // Discard other actions, wipe and lock the issue.
+      // This function used to block the user during a major spam incident
+      // but since then blocking has been removed.
       const reason = `Issue is believed to be spam: ${issue.title}`;
       return [
         new types.GitHubSpamAction(org, name, issue.number, reason),
-        new types.GitHubBlockAction(org, issue.user.login),
         new types.GitHubLockAction(org, name, issue.number),
       ];
     }
@@ -367,11 +365,11 @@ export class IssueHandler {
     label: string,
   ): types.Action[] {
     // Render the issue body
-    const body_html = marked(issue.body || "");
+    const body_html = marked.parse(issue.body || "", { async: false });
 
     // Send a new issue email
     const action = this.emailer.getIssueUpdateEmailAction(repo, issue, {
-      header: `New Issue from ${issue.user.login} in label ${label}`,
+      header: `New Issue from ${issue.user?.login ?? "ghost"} in label ${label}`,
       body: body_html,
       label: label,
     });
@@ -405,7 +403,7 @@ export class IssueHandler {
     const actions: types.Action[] = [];
 
     // Send an email to subscribers
-    const comment_html = marked(comment.body);
+    const comment_html = marked.parse(comment.body, { async: false });
     const emailAction = this.emailer.getIssueUpdateEmailAction(repo, issue, {
       header: `New Comment by ${comment.user.login}`,
       body: comment_html,
@@ -426,12 +424,19 @@ export class IssueHandler {
 
     if (cleanupConfig && cleanupConfig.issue && !isBotComment && !isClosed) {
       const issueConfig = cleanupConfig.issue;
-      const labelNames = issue.labels.map((label) => label.name);
+      const labelNames = issue.labels.map((label) => {
+        if (typeof label === "string") {
+          return label;
+        }
+        return label.name;
+      });
 
       const isNeedsInfo = labelNames.includes(issueConfig.label_needs_info);
       const isStale = labelNames.includes(issueConfig.label_stale);
 
-      const isAuthorComment = comment.user.login === issue.user.login;
+      const isAuthorComment = issue.user
+        ? comment.user.login === issue.user.login
+        : false;
 
       if (isStale) {
         // Any comment on a stale issue removes the stale flag
@@ -452,7 +457,7 @@ export class IssueHandler {
           : issueConfig.label_needs_info;
 
         const reason = isAuthorComment
-          ? `Comment by the author (${issue.user.login}) on a stale issue moves this to needs_attention`
+          ? `Comment by the author (${issue.user?.login ?? "ghost"}) on a stale issue moves this to needs_attention`
           : `Comment by a non-author (${comment.user.login}) on a stale issue moves this to needs_info`;
 
         if (isAuthorComment && !issueConfig.label_needs_attention) {
@@ -476,7 +481,7 @@ export class IssueHandler {
 
       if (isNeedsInfo && isAuthorComment) {
         // An author comment on a needs-info issue moves it to needs-attention.
-        const reason = `Comment by the author (${issue.user.login}) moves this from needs_info to needs_attention.`;
+        const reason = `Comment by the author (${issue.user?.login ?? "ghost"}) moves this from needs_info to needs_attention.`;
         actions.push(
           new types.GitHubRemoveLabelAction(
             org,
@@ -785,7 +790,7 @@ export class IssueHandler {
     const path_re = /template_path=(.*)/;
     const validate_re = /validate_template=(.*)/;
 
-    const body = issue.body;
+    const body = issue.body ?? "";
 
     const path_match = body.match(path_re);
     if (path_match) {

functions/src/pullrequests.ts

@@ -71,7 +71,9 @@ export class PullRequestHandler {
       case PullRequestAction.OPENED:
         return this.onNewPullRequest(repo, pr);
       case PullRequestAction.LABELED:
-        return this.onPullRequestLabeled(repo, pr, event.label.name);
+        if (event.label.name) {
+          return this.onPullRequestLabeled(repo, pr, event.label.name);
+        }
       case PullRequestAction.ASSIGNED:
       /* falls through */
       case PullRequestAction.UNASSIGNED:
@@ -128,7 +130,7 @@ export class PullRequestHandler {
     label: string,
   ): Promise<types.Action[]> {
     // Render the PR body
-    const body_html = marked(pr.body || "");
+    const body_html = marked.parse(pr.body || "", { async: false });
 
     // Send a new PR email
     const action = this.emailer.getIssueUpdateEmailAction(repo, pr, {