Follow up fixes to #95 for #92

Author: samtstern

functions/src/cron.ts

@@ -61,6 +61,9 @@ export class CronHandler {
       [issueConfig.label_needs_info]
     );
 
+    log.debug(
+      `preProcessIssues: ${needsInfoIssues.length} issues witth label ${issueConfig.label_needs_info}`
+    );
     for (const issue of needsInfoIssues) {
       const issueActions = await this.doubleCheckNeedsInfo(
         org,
@@ -290,6 +293,11 @@ export class CronHandler {
     let comments = await this.gh_client.getCommentsForIssue(org, name, number);
     comments = comments.sort(util.compareTimestamps).reverse();
 
+    if (!comments || comments.length === 0) {
+      console.log(`Issue ${name}#${number} has no comments.`);
+      return actions;
+    }
+
     // When the issue was marked stale, the bot will have left a comment with certain metadata
     const markStaleComment = comments.find(comment => {
       return comment.body.includes(EVT_MARK_STALE);

functions/src/github.ts

@@ -177,15 +177,17 @@ export class GitHubClient {
     state?: IssueState,
     labels?: string[]
   ) {
-    const stateFilter = state || "all";
-    const labelsFilter = labels === undefined ? undefined : labels.join(",");
-
-    return paginate(this.api.issues.listForRepo, {
+    const opts: any = {
       owner,
       repo,
-      state: stateFilter,
-      labels: labelsFilter
-    });
+      state: state || "all"
+    };
+
+    if (labels && labels.length > 0) {
+      opts.labels = labels.join(",");
+    }
+
+    return paginate(this.api.issues.listForRepo, opts);
   }
 
   /**