refactor(js): moved ALS code into separate node specific package #3061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifielker
approved these changes
Jun 11, 2025
| * Creates a new child registry overlaid onto this registry instance. | ||
| */ | ||
| child(): Registry { | ||
| throw new Error('Method not implemented.'); |
There was a problem hiding this comment.
Shouldn't we implement the new way before deprecating the old one? (Or at least a the same time). It can be frustrating to have something be deprecated and the replacement unimplemented.
| @@ -264,7 +265,7 @@ describe('registry class', () => { | |||
| }); | |||
|
|
|||
| it('returns all registered actions, including parent', async () => { | |||
| const child = Registry.withParent(registry); | |||
| const child = registry.child(); | |||
There was a problem hiding this comment.
If child is unimplemented, how does this test work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (if applicable):