-
Notifications
You must be signed in to change notification settings - Fork 4.1k
chore: add license header for missing files #9703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add license header for missing files #9703
Conversation
|
I have added the missing headers with On which files do we want to add the license headers? I just used the default settings of |
This reverts commit d32bcf4.
…**/*.yaml" --ignore "**/*.xml" --ignore "**/*.g.dart" --ignore "**/*.sh" --ignore "**/*.html" --ignore "**/*.js" --ignore "**/*.ts" --ignore "**/*.g.h" --ignore "**/*.g.m" --ignore "**/*.rb" .`
…ignore "**/*.yaml" --ignore "**/*.xml" --ignore "**/*.g.dart" --ignore "**/*.sh" --ignore "**/*.html" --ignore "**/*.js" --ignore "**/*.ts" --ignore "**/*.g.h" --ignore "**/*.g.m" --ignore "**/*.rb" .`" This reverts commit 886eec4.
…**/*.yaml" --ignore "**/*.xml" --ignore "**/*.g.dart" --ignore "**/*.sh" --ignore "**/*.html" --ignore "**/*.js" --ignore "**/*.ts" --ignore "**/*.g.h" --ignore "**/*.g.m" --ignore "**/*.rb" --ignore "**/Runner/AppDelegate.swift" --ignore "**/Runner/MainFlutterWindow.swift" --ignore "**/Runner/Runner-Bridging-Header.h" --ignore "**/Runner/AppDelegate.h" --ignore "**/Runner/AppDelegate.m" --ignore "**/Runner/main.m" --ignore "**/MainActivity.kt" --ignore "**/MainActivity.java" --ignore "**/FlutterMultiDexApplication.java" --ignore **/GeneratedPluginRegistrant.swift .`
Discussed in Slack: We are going to use these ignore flags: |
|
This is the second part: #9704 |
Lyokone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there are some conflicts, if you can fix them, I'll try to get that merged quickly :)
|
@Lyokone Thanks for the review :) I solved the conflicts 👍 |
Description
I'm going to split #9702 into two PRs:
meloscommand to add & check license header #9704)I used this command (in the next PR I'm going to add this as a
meloscommand):with this in my
header_template.txtCopyright {{.Year}}, the Chromium project authors. Please see the AUTHORS file for details. All rights reserved. Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.Related Issues
Part of #9702
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?