-
Notifications
You must be signed in to change notification settings - Fork 4.1k
test: migrate all packages from Flutter driver to integration tests #9230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `integration_test.dart` * Add dummy `e2e_test.dart` file * Add `integration_test` package * Run integration tests for every pull request * Use `IntegrationTestWidgetsFlutterBinding.ensureInitialized();` * Format & use `flutter test` * Use multidex * Add new line for `FlutterMultiDexApplication.java` * Format to pass CI * Add comment for `flutter drive` command * Use `flutter test` command for macos test * Format test command for android * Use one line comment * Re-trigger CI * Re-trigger CI * Bump `minSdkVersion` to 21 for tests app
* Migrate `firebase_core` * Add license in `e2e_test.dart` * Add `IntegrationTestWidgetsFlutterBinding.ensureInitialized();` to `firebase_core_e2e_test.dart` * Use `flutter_test` instead of `drive` package * Fix `firebase_options.dart` file
…ge (#8947) Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
* Add `sample_data.dart` * Add `cloud_functions_e2e_test.dart` * Use cloud functions tests * Remove ignore lint comment * Re-trigger CI Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
…ge (#8973) Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
#8977) Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
…8975) Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
…8974) Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
Co-authored-by: Nils Reichardt <nils@reichardt.io>
10 tasks
Co-authored-by: Remi Rousselet <darky12s@gmail.com>
# Conflicts: # packages/cloud_firestore_odm/cloud_firestore_odm_generator/lib/src/validator_generator.dart # tests/android/app/build.gradle # tests/android/app/src/main/java/io/flutter/app/FlutterMultiDexApplication.java
Member
|
Hey @nilsreichardt, I've fixed the merge conflicts for you. Let me know if you need any further assistance 🙏 |
Contributor
Author
|
Thanks, @russellwheatley 🙏 |
Contributor
Author
|
Hey @russellwheatley, could you again merge the |
Member
|
Done, @nilsreichardt 😄 |
Contributor
Author
|
I started from scratch and opened a new PR where I migrated all packages in one PR: #9649 |
38 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
integration_testpackage is the new way to write e2e tests. Therefore, this PR migrates the tests from driver tests to integration tests.As side effect, we see that the Android CI e2e tests pipeline is way more stable.
ToDos:
cloud_firestorecloud_functionsfirebase_analyticsfirebase_app_installationsfirebase_authfirebase_corefirebase_crashlyticsfirebase_databasefirebase_dynamic_linksfirebase_in_app_messagingfirebase_ml_model_downloaderfirebase_remote_configfirebase_messagingfirebase_storagefirebase_firestore_odmfirebase_performancedriveas dependencydrivedependency on pub.dev as discontinued?Related Issues
Closes #8909
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?