Skip to content

Conversation

@russellwheatley
Copy link
Member

  • Add integration_test.dart

  • Add dummy e2e_test.dart file

  • Add integration_test package

  • Run integration tests for every pull request

  • Use IntegrationTestWidgetsFlutterBinding.ensureInitialized();

  • Format & use flutter test

  • Use multidex

  • Add new line for FlutterMultiDexApplication.java

  • Format to pass CI

  • Add comment for flutter drive command

  • Use flutter test command for macos test

  • Format test command for android

  • Use one line comment

  • Re-trigger CI

  • Re-trigger CI

  • Bump minSdkVersion to 21 for tests app## Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

nilsreichardt and others added 11 commits June 15, 2022 14:36
* Add `integration_test.dart`

* Add dummy `e2e_test.dart` file

* Add `integration_test` package

* Run integration tests for every pull request

* Use `IntegrationTestWidgetsFlutterBinding.ensureInitialized();`

* Format & use `flutter test`

* Use multidex

* Add new line for `FlutterMultiDexApplication.java`

* Format to pass CI

* Add comment for `flutter drive` command

* Use `flutter test` command for macos test

* Format test command for android

* Use one line comment

* Re-trigger CI

* Re-trigger CI

* Bump `minSdkVersion` to 21 for tests app
* Migrate `firebase_core`

* Add license in `e2e_test.dart`

* Add `IntegrationTestWidgetsFlutterBinding.ensureInitialized();` to `firebase_core_e2e_test.dart`

* Use `flutter_test` instead of `drive` package

* Fix `firebase_options.dart` file
…ge (#8947)

Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
* Add `sample_data.dart`

* Add `cloud_functions_e2e_test.dart`

* Use cloud functions tests

* Remove ignore lint comment

* Re-trigger CI

Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
…ge (#8973)

Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
#8977)

Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
…8975)

Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
…8974)

Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
@nilsreichardt
Copy link
Contributor

nilsreichardt commented Jul 20, 2022

Description for this PR:

## Description

The `integration_test` package is the new way to write e2e tests. Therefore, this PR migrates the tests from driver tests to integration tests.

ToDos:

- [ ] Update description for this PR
- [ ] Update title of the PR to "test: migrate all packages from driver tests to integration tests"
- [ ] Migrate `cloud_firestore`
- [x] Migrate `cloud_functions`
- [x] Migrate `firebase_analytics`
- [x] Migrate `firebase_app_installations`
- [x] Migrate `firebase_auth`
- [x] Migrate `firebase_core`
- [x] Migrate `firebase_crashlytics`
- [x] Migrate `firebase_database`
- [x] Migrate `firebase_dynamic_links`
- [x] Migrate `firebase_in_app_messaging`
- [ ] Migrate `firebase_ml_model_downloader`
- [ ] Migrate `firebase_remote_config`
- [x] Migrate `firebase_messaging`
- [ ] Migrate `firebase_storage`
- [ ] Migrate `firebase_firestore_odm`
- [ ] Migrate `firebase_performance`
- [ ] Delete driver tests (test_driver/ folder)
- [ ] Remove `drive` as dependency
- [ ] Mark `drive` dependency on pub.dev as discontinued?
- [ ] Check if CI is flaky (run CI 50 times)
- [ ] Update docs on how to run integration tests

As side effect we see that the Android CI e2e tests pipeline is way more stable.

## Related Issues

Closes #8909

## Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`).
This will ensure a smooth and quick review process. Updating the `pubspec.yaml` and changelogs is not required.

- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] My PR includes unit or integration tests for *all* changed/updated/fixed behaviors (See [Contributor Guide]).
- [x] All existing and new tests are passing.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] The analyzer (`melos run analyze`) does not report any problems on my PR.
- [x] I read and followed the [Flutter Style Guide].
- [x] I signed the [CLA].
- [x] I am willing to follow-up on review comments in a timely manner.

## Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

- [ ] Yes, this is a breaking change.
- [x] No, this is *not* a breaking change.

<!-- Links -->
[issue database]: https://github.com/flutter/flutter/issues
[Contributor Guide]: https://github.com/firebase/flutterfire/blob/master/CONTRIBUTING.md
[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[pub versioning philosophy]: https://dart.dev/tools/pub/versioning
[CLA]: https://cla.developers.google.com/

Co-authored-by: Nils Reichardt <nils@reichardt.io>
@nilsreichardt
Copy link
Contributor

Will be continued in #9230

@firebase firebase locked and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

blocked: do-not-merge PR blocked externally type: infrastructure Improvements to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants