Skip to content

Conversation

@nilsreichardt
Copy link
Contributor

Description

Migrates the Flutter Driver tests to Flutter Integration tests. I just copied the Flutter Driver. So I have not changed any test.

Related Issues

Part of #6829

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added the type: infrastructure Improvements to the codebase label Jul 11, 2022
@nilsreichardt
Copy link
Contributor Author

I think I need to fix this broken CI

@russellwheatley russellwheatley marked this pull request as ready for review July 18, 2022 08:07
@russellwheatley russellwheatley merged commit 7b6f69b into firebase:migrate-to-integration-tests Jul 18, 2022
@russellwheatley
Copy link
Member

@nilsreichardt The android CI is pretty flaky at the moment. But I've noticed that these integration tests are way less flaky than the previous implementation using drive.

@nilsreichardt
Copy link
Contributor Author

@russellwheatley Yeah, I have also see feeling. I'm not sure if it's worth to invest more time in #9076 🤔 I have also planned to make a stability test when I migrated every package (similar I need with the all_plugins jobs)

@russellwheatley
Copy link
Member

@nilsreichardt but if you wanted to raise the last PRs for the integration tests update (ml model downloader, storage & app check) for the e2e tests, that would be awesome 👍

@russellwheatley
Copy link
Member

@nilsreichardt yes, I'm going to leave that PR because I think this should really improve the e2e tests 😄

@nilsreichardt
Copy link
Contributor Author

@russellwheatley I'm going to do it this week :)

@firebase firebase locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type: infrastructure Improvements to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants