test(firebase_core): migrate to integration_test package
#8928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsreichardt
commented
Jun 19, 2022
| void main() { | ||
| IntegrationTestWidgetsFlutterBinding.ensureInitialized(); | ||
|
|
||
| // ignore: unnecessary_lambdas |
Contributor
Author
There was a problem hiding this comment.
This line will be remove when I migrated a second package.
| @@ -0,0 +1,81 @@ | |||
| // Copyright 2019, the Chromium project authors. Please see the AUTHORS file | |||
Contributor
Author
There was a problem hiding this comment.
A difference to the Flutter Driver tests is that I called the file firebase_core_e2e_test.dart instead of firebase_core_e2e.dart.
This has the advantage that IDEs detects that this is a test file. Therefore, you are able to easily start and debug the tests via the IDE.
| import 'package:flutter/foundation.dart'; | ||
| import 'package:flutter_test/flutter_test.dart'; | ||
| import 'package:integration_test/integration_test.dart'; | ||
| import 'package:tests/firebase_options.dart'; |
Contributor
Author
There was a problem hiding this comment.
Another difference to the Flutter Drivers tests is that I'm using the firebase_options.dart file from the lib instead of copying it again in the integration_test folder (like it has been done in the test_driver folder).
Lyokone
approved these changes
Jun 20, 2022
russellwheatley
approved these changes
Jun 20, 2022
nilsreichardt
changed the title
integration_test packageintegration_test package
This was referenced Jun 20, 2022
Lyokone
approved these changes
Jun 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the Flutter Driver tests to Flutter Integration tests. I just copied the Flutter Driver. So have not changed any test.
Related Issues
Part of #6829
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?