ci: configure GitHub Actions to use integration_test package
#8910
Conversation
| targetSdkVersion flutter.targetSdkVersion | ||
| versionCode flutterVersionCode.toInteger() | ||
| versionName flutterVersionName | ||
| multiDexEnabled true |
There was a problem hiding this comment.
I needed to use multiDex to fix the flutter test command. Is this a problem that I'm adding multiDex?
Output of the exception (without multiDex): https://github.com/nilsreichardt/flutterfire/runs/6877416338?check_suite_focus=true
There was a problem hiding this comment.
I think multidex is automatically added with minSdkVersion 21, do we want to keep the 19 version? The Android repartition is really low for this SDK 🤔
There was a problem hiding this comment.
+1 for bumping minSdkVersion to 21 on test apps, multidex <21 has caused headaches for me before on other CI things (though this was a while back and on RNFirebase)
There was a problem hiding this comment.
Bumping the minSdkVersion to 21 in 622cd46 ✅
| targetSdkVersion flutter.targetSdkVersion | ||
| versionCode flutterVersionCode.toInteger() | ||
| versionName flutterVersionName | ||
| multiDexEnabled true |
There was a problem hiding this comment.
I think multidex is automatically added with minSdkVersion 21, do we want to keep the 19 version? The Android repartition is really low for this SDK 🤔
…ase#8910) * Add `integration_test.dart` * Add dummy `e2e_test.dart` file * Add `integration_test` package * Run integration tests for every pull request * Use `IntegrationTestWidgetsFlutterBinding.ensureInitialized();` * Format & use `flutter test` * Use multidex * Add new line for `FlutterMultiDexApplication.java` * Format to pass CI * Add comment for `flutter drive` command * Use `flutter test` command for macos test * Format test command for android * Use one line comment * Re-trigger CI * Re-trigger CI * Bump `minSdkVersion` to 21 for tests app
3 participants
Description
This will be the scaffold for #8909. It's the first PR for migrating the tests to the
integration_testpackage. The other PRs for migrating the packages will follow in the next weeks.Related Issues
Part of #8909
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?