Skip to content

chore: Migrate firebase_core to nnbd #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jan 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
312006d
Enables more lints
rrousselGit Jan 13, 2021
a3a04bf
Migrate firebase_core to non-nullable types
rrousselGit Jan 13, 2021
0a70de7
Self review
rrousselGit Jan 13, 2021
a9ed957
Self review
rrousselGit Jan 13, 2021
2410bdf
update cloud_firestore/firebase_storage/firebase_auth's example pubsp…
rrousselGit Jan 14, 2021
19e2883
update SDK version constraints
rrousselGit Jan 14, 2021
18bc656
force CI to rerun
rrousselGit Jan 14, 2021
f28c980
Merge branch 'master' of https://github.com/FirebaseExtended/flutterf…
rrousselGit Jan 14, 2021
2a1dab9
update melos constraints
rrousselGit Jan 14, 2021
a47a75b
use dev channel instead of stable
rrousselGit Jan 14, 2021
976fc47
use dependency_overrides to fix quiver version
rrousselGit Jan 14, 2021
7225a33
more dependency_overrides
rrousselGit Jan 14, 2021
3b25757
dep_override examples
rrousselGit Jan 14, 2021
16c7208
crashlytics dep_overrides
rrousselGit Jan 14, 2021
05f71b3
fix dart version at 2.9 on crashlytics
rrousselGit Jan 14, 2021
e3e4add
Merge branch 'master' of https://github.com/FirebaseExtended/flutterf…
rrousselGit Jan 14, 2021
cac02f8
firebase_core_platform_interface dependency override
rrousselGit Jan 14, 2021
a1b6ba5
fix firebase_core CI
rrousselGit Jan 14, 2021
1d73c40
fix firebase_core example
rrousselGit Jan 14, 2021
344310b
update examples firebase_core_platform_interface
rrousselGit Jan 14, 2021
6803b55
add dart=2.9 on all non-migrated code
rrousselGit Jan 14, 2021
e14e550
more dependency_overrides
rrousselGit Jan 14, 2021
6765d02
fix firebase_remote_config example
rrousselGit Jan 14, 2021
03f904c
fix typo in dependency_override
rrousselGit Jan 14, 2021
053473b
replace `flutter build aot` with `flutter build apk`
rrousselGit Jan 14, 2021
0f6568f
skip example build in favor of the analyzer
rrousselGit Jan 14, 2021
b2d9e69
revert removal of --ignore="example" for pub publish
rrousselGit Jan 14, 2021
83f5ade
Add missing dart=2.9 in firebase_database/example
rrousselGit Jan 14, 2021
d5b92b6
fix analyzer warnings
rrousselGit Jan 14, 2021
2448406
fix missing unoverriden dependencies
rrousselGit Jan 14, 2021
9ec1b7d
remove dartdoc about `null`
rrousselGit Jan 15, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
12 changes: 6 additions & 6 deletions .github/workflows/all_plugins.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: |
./.github/workflows/scripts/install-tools.sh
Expand All @@ -41,7 +41,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: |
./.github/workflows/scripts/install-tools.sh
Expand All @@ -58,7 +58,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: |
./.github/workflows/scripts/install-tools.sh
Expand Down Expand Up @@ -91,15 +91,15 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Bootstrap Workspace"
run: melos bootstrap
- name: "Build Example Snapshots"
run: |
melos exec -c 1 --scope="*example*" -- \
"flutter --suppress-analytics build aot"
"flutter --suppress-analytics build apk"

test:
runs-on: ubuntu-latest
Expand All @@ -109,7 +109,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Bootstrap Workspace"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/firebase_admob.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Build Example"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/firebase_analytics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Build Example"
Expand All @@ -48,7 +48,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Build Example"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/firebase_auth.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Build Example"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/firebase_core.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Build Example"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/firebase_crashlytics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Build Example"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/firebase_database.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Build Example"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/firebase_firestore.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: |
./.github/workflows/scripts/install-tools.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/firebase_functions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: |
./.github/workflows/scripts/install-tools.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/firebase_messaging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Build Example"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/firebase_performance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Build Example"
Expand All @@ -47,7 +47,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Build Example"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/firebase_remote_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Build Example"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/firebase_storage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
with:
fetch-depth: 0
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
run: ./.github/workflows/scripts/install-flutter.sh dev
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
- name: "Build Example"
Expand Down
2 changes: 1 addition & 1 deletion melos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -178,5 +178,5 @@ dev_dependencies:
pedantic: 1.8.0

environment:
sdk: ">=2.1.0 <3.0.0"
sdk: ">=2.12.0-0 <3.0.0"
flutter: ">=1.12.13+hotfix.5 <2.0.0"
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'package:flutter/material.dart';
import 'package:firebase_core/firebase_core.dart';
import 'package:cloud_firestore/cloud_firestore.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: cloud_firestore_example
description: Demonstrates how to use the firestore plugin.

environment:
sdk: ">=2.1.0 <3.0.0"
sdk: ">=2.12.0-0 <3.0.0"
flutter: ">=1.12.13+hotfix.4 <2.0.0"

dependencies:
Expand All @@ -16,6 +16,8 @@ dependencies:
dependency_overrides:
firebase_core:
path: ../../../firebase_core/firebase_core
firebase_core_platform_interface:
path: ../../../firebase_core/firebase_core_platform_interface
cloud_firestore_platform_interface:
path: ../../cloud_firestore_platform_interface

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'package:cloud_firestore/cloud_firestore.dart';
import 'package:drive/drive.dart' as drive;
import 'package:firebase_core/firebase_core.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'package:drive/drive_driver.dart' as drive;

void main() => drive.main();
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'dart:math';

import 'package:flutter_test/flutter_test.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'dart:async';

import 'package:flutter_test/flutter_test.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'dart:async';

import 'package:flutter/foundation.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'dart:async';

import 'package:flutter_test/flutter_test.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'dart:async';

import 'package:flutter_test/flutter_test.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'dart:async';

import 'package:flutter/foundation.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'dart:math';
import 'dart:async';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'dart:async';

import 'package:flutter/foundation.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'dart:async';

import 'package:flutter_test/flutter_test.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'dart:async';
import 'dart:math';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'dart:async';

import 'package:flutter/foundation.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

library cloud_firestore;

import 'package:cloud_firestore_platform_interface/cloud_firestore_platform_interface.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

part of cloud_firestore;

/// A [CollectionReference] object can be used for adding documents, getting
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

part of cloud_firestore;

/// A [DocumentChange] represents a change to the documents matching a query.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

part of cloud_firestore;

/// A [DocumentReference] refers to a document location in a [FirebaseFirestore] database
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

part of cloud_firestore;

/// A [DocumentSnapshot] contains data read from a document in your [FirebaseFirestore]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

part of cloud_firestore;

/// Sentinel values that can be used when writing document fields with set() or
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

part of cloud_firestore;

/// The entry point for accessing a [FirebaseFirestore].
Expand Down
Loading