Skip to content

refactor(firebase_crashlytics)!: remove deprecated APIs #4595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -31,24 +31,6 @@ class FirebaseCrashlytics extends FirebasePluginPlatform {
return _instance ??= FirebaseCrashlytics._(app: Firebase.app());
}

/// Whether the current Crashlytics instance is collecting reports. If false,
/// then no crash reporting data is sent to Firebase.
///
/// See [setCrashlyticsCollectionEnabled] for toggling collection status.
@Deprecated(
"enableInDevMode getter is deprecated, use 'isCrashlyticsCollectionEnabled' instead")
bool get enableInDevMode {
return _delegate.isCrashlyticsCollectionEnabled;
}

/// Whether the current Crashlytics instance is collecting reports. If false,
/// then no crash reporting data is sent to Firebase.
@Deprecated(
"enableInDevMode setter is deprecated, use 'setCrashlyticsCollectionEnabled(bool)' instead")
set enableInDevMode(bool enabled) {
_delegate.setCrashlyticsCollectionEnabled(enabled).then((value) => null);
}

/// Whether the current Crashlytics instance is collecting reports. If false,
/// then no crash reporting data is sent to Firebase.
///
Expand Down Expand Up @@ -219,21 +201,3 @@ class FirebaseCrashlytics extends FirebasePluginPlatform {
return _delegate.setCustomKey(key, value.toString());
}
}

/// Extends the [FirebaseCrashlytics] class to allow for deprecated usage of
/// using [Crashlytics] directly.
@Deprecated(
"Class Crashlytics is deprecated. Use 'FirebaseCrashlytics' instead.")
class Crashlytics extends FirebaseCrashlytics {
// ignore: public_member_api_docs
@Deprecated(
"Constructing Crashlytics is deprecated, use 'FirebaseCrashlytics.instance' instead")
factory Crashlytics() {
return FirebaseCrashlytics.instance;
}

@Deprecated(
"Accessing Crashlytics.instance is deprecated, use 'FirebaseCrashlytics.instance' instead")
// ignore: public_member_api_docs
static FirebaseCrashlytics get instance => FirebaseCrashlytics.instance;
}