Skip to content

Commit 8f168e6

Browse files
author
Michael Klimushyn
authored
[firebase_ml_vision] Set minimum iOS to 8 (#1106)
This is the lowest version of iOS supported by Flutter. Supporting lower versions was causing build failures in CI.
1 parent e760f22 commit 8f168e6

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed

‎packages/firebase_ml_vision/example/ios/Runner.xcodeproj/project.pbxproj‎

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,12 @@
88

99
/* Begin PBXBuildFile section */
1010
1498D2341E8E89220040F4C2 /* GeneratedPluginRegistrant.m in Sources */ = {isa = PBXBuildFile; fileRef = 1498D2331E8E89220040F4C2 /* GeneratedPluginRegistrant.m */; };
11-
2D5378261FAA1A9400D5DBA9 /* flutter_assets in Resources */ = {isa = PBXBuildFile; fileRef = 2D5378251FAA1A9400D5DBA9 /* flutter_assets */; };
1211
3B3967161E833CAA004F5970 /* AppFrameworkInfo.plist in Resources */ = {isa = PBXBuildFile; fileRef = 3B3967151E833CAA004F5970 /* AppFrameworkInfo.plist */; };
1312
3B80C3941E831B6300D905FE /* App.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 3B80C3931E831B6300D905FE /* App.framework */; };
1413
3B80C3951E831B6300D905FE /* App.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 3B80C3931E831B6300D905FE /* App.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
1514
8FDA56F920D046020020E776 /* GoogleService-Info.plist in Resources */ = {isa = PBXBuildFile; fileRef = 8FDA56F820D046020020E776 /* GoogleService-Info.plist */; };
1615
9705A1C61CF904A100538489 /* Flutter.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 9740EEBA1CF902C7004384FC /* Flutter.framework */; };
1716
9705A1C71CF904A300538489 /* Flutter.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 9740EEBA1CF902C7004384FC /* Flutter.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
18-
9740EEB41CF90195004384FC /* Debug.xcconfig in Resources */ = {isa = PBXBuildFile; fileRef = 9740EEB21CF90195004384FC /* Debug.xcconfig */; };
19-
9740EEB51CF90195004384FC /* Generated.xcconfig in Resources */ = {isa = PBXBuildFile; fileRef = 9740EEB31CF90195004384FC /* Generated.xcconfig */; };
2017
978B8F6F1D3862AE00F588F7 /* AppDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = 7AFFD8EE1D35381100E5BB4D /* AppDelegate.m */; };
2118
97C146F31CF9000F007C117D /* main.m in Sources */ = {isa = PBXBuildFile; fileRef = 97C146F21CF9000F007C117D /* main.m */; };
2219
97C146FC1CF9000F007C117D /* Main.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FA1CF9000F007C117D /* Main.storyboard */; };
@@ -43,7 +40,6 @@
4340
/* Begin PBXFileReference section */
4441
1498D2321E8E86230040F4C2 /* GeneratedPluginRegistrant.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = GeneratedPluginRegistrant.h; sourceTree = "<group>"; };
4542
1498D2331E8E89220040F4C2 /* GeneratedPluginRegistrant.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = GeneratedPluginRegistrant.m; sourceTree = "<group>"; };
46-
2D5378251FAA1A9400D5DBA9 /* flutter_assets */ = {isa = PBXFileReference; lastKnownFileType = folder; name = flutter_assets; path = Flutter/flutter_assets; sourceTree = SOURCE_ROOT; };
4743
3B3967151E833CAA004F5970 /* AppFrameworkInfo.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = AppFrameworkInfo.plist; path = Flutter/AppFrameworkInfo.plist; sourceTree = "<group>"; };
4844
3B80C3931E831B6300D905FE /* App.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = App.framework; path = Flutter/App.framework; sourceTree = "<group>"; };
4945
47511359F254D1FA05DF3B06 /* libPods-Runner.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = "libPods-Runner.a"; sourceTree = BUILT_PRODUCTS_DIR; };
@@ -87,7 +83,6 @@
8783
9740EEB11CF90186004384FC /* Flutter */ = {
8884
isa = PBXGroup;
8985
children = (
90-
2D5378251FAA1A9400D5DBA9 /* flutter_assets */,
9186
3B80C3931E831B6300D905FE /* App.framework */,
9287
3B3967151E833CAA004F5970 /* AppFrameworkInfo.plist */,
9388
9740EEBA1CF902C7004384FC /* Flutter.framework */,
@@ -181,7 +176,7 @@
181176
97C146E61CF9000F007C117D /* Project object */ = {
182177
isa = PBXProject;
183178
attributes = {
184-
LastUpgradeCheck = 0910;
179+
LastUpgradeCheck = 1000;
185180
ORGANIZATIONNAME = "The Chromium Authors";
186181
TargetAttributes = {
187182
97C146ED1CF9000F007C117D = {
@@ -214,11 +209,8 @@
214209
files = (
215210
97C147011CF9000F007C117D /* LaunchScreen.storyboard in Resources */,
216211
8FDA56F920D046020020E776 /* GoogleService-Info.plist in Resources */,
217-
9740EEB51CF90195004384FC /* Generated.xcconfig in Resources */,
218212
3B3967161E833CAA004F5970 /* AppFrameworkInfo.plist in Resources */,
219-
9740EEB41CF90195004384FC /* Debug.xcconfig in Resources */,
220213
97C146FE1CF9000F007C117D /* Assets.xcassets in Resources */,
221-
2D5378261FAA1A9400D5DBA9 /* flutter_assets in Resources */,
222214
97C146FC1CF9000F007C117D /* Main.storyboard in Resources */,
223215
);
224216
runOnlyForDeploymentPostprocessing = 0;
@@ -247,7 +239,7 @@
247239
);
248240
inputPaths = (
249241
"${SRCROOT}/Pods/Target Support Files/Pods-Runner/Pods-Runner-frameworks.sh",
250-
"${PODS_ROOT}/../.symlinks/flutter/ios/Flutter.framework",
242+
"${PODS_ROOT}/../.symlinks/flutter/ios-release/Flutter.framework",
251243
);
252244
name = "[CP] Embed Pods Frameworks";
253245
outputPaths = (
@@ -359,12 +351,14 @@
359351
CLANG_WARN_BOOL_CONVERSION = YES;
360352
CLANG_WARN_COMMA = YES;
361353
CLANG_WARN_CONSTANT_CONVERSION = YES;
354+
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
362355
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
363356
CLANG_WARN_EMPTY_BODY = YES;
364357
CLANG_WARN_ENUM_CONVERSION = YES;
365358
CLANG_WARN_INFINITE_RECURSION = YES;
366359
CLANG_WARN_INT_CONVERSION = YES;
367360
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
361+
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
368362
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
369363
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
370364
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
@@ -413,12 +407,14 @@
413407
CLANG_WARN_BOOL_CONVERSION = YES;
414408
CLANG_WARN_COMMA = YES;
415409
CLANG_WARN_CONSTANT_CONVERSION = YES;
410+
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
416411
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
417412
CLANG_WARN_EMPTY_BODY = YES;
418413
CLANG_WARN_ENUM_CONVERSION = YES;
419414
CLANG_WARN_INFINITE_RECURSION = YES;
420415
CLANG_WARN_INT_CONVERSION = YES;
421416
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
417+
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
422418
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
423419
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
424420
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
@@ -459,6 +455,7 @@
459455
"$(PROJECT_DIR)/Flutter",
460456
);
461457
INFOPLIST_FILE = Runner/Info.plist;
458+
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
462459
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
463460
LIBRARY_SEARCH_PATHS = (
464461
"$(inherited)",
@@ -482,6 +479,7 @@
482479
"$(PROJECT_DIR)/Flutter",
483480
);
484481
INFOPLIST_FILE = Runner/Info.plist;
482+
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
485483
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
486484
LIBRARY_SEARCH_PATHS = (
487485
"$(inherited)",

‎packages/firebase_ml_vision/example/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
3+
<plist version="1.0">
4+
<dict>
5+
<key>IDEDidComputeMac32BitWarning</key>
6+
<true/>
7+
</dict>
8+
</plist>

‎packages/firebase_ml_vision/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0910"
3+
LastUpgradeVersion = "1000"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"
@@ -26,7 +26,6 @@
2626
buildConfiguration = "Debug"
2727
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
2828
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
29-
language = ""
3029
shouldUseLaunchSchemeArgsEnv = "YES">
3130
<Testables>
3231
</Testables>
@@ -46,7 +45,6 @@
4645
buildConfiguration = "Debug"
4746
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
4847
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
49-
language = ""
5048
launchStyle = "0"
5149
useCustomWorkingDirectory = "NO"
5250
ignoresPersistentStateOnLaunch = "NO"

0 commit comments

Comments
 (0)