fix: Add speculative fix for null object reference crash (#9671)

ChristianEdwardPadilla · web-flow · commit 6c00368580a0 · 2022-10-10T08:54:13.000+02:00
* Add speculative fix for null object reference crash The activity is accessed potentially unsafely, and we are seeing some null reference crashes from this file. See: #9544 * Fix null equality checks * Mark link as used before retrieving from intent * Format
diff --git a/packages/firebase_dynamic_links/firebase_dynamic_links/android/src/main/java/io/flutter/plugins/firebase/dynamiclinks/FlutterFirebaseDynamicLinksPlugin.java b/packages/firebase_dynamic_links/firebase_dynamic_links/android/src/main/java/io/flutter/plugins/firebase/dynamiclinks/FlutterFirebaseDynamicLinksPlugin.java
@@ -236,10 +236,10 @@ private Task<Map<String, Object>> getDynamicLink(
                 taskCompletionSource.setResult(null);
                 return;
               }
-              pendingDynamicLink =
-                  Tasks.await(dynamicLinks.getDynamicLink(activity.get().getIntent()));
 
               activity.get().getIntent().putExtra("flutterfire-used-link", true);
+              pendingDynamicLink =
+                  Tasks.await(dynamicLinks.getDynamicLink(activity.get().getIntent()));
             }
 
             taskCompletionSource.setResult(

Original file line number	Diff line number	Diff line change
`@@ -236,10 +236,10 @@ private Task<Map<String, Object>> getDynamicLink(`
`236`	`236`	`taskCompletionSource.setResult(null);`
`237`	`237`	`return;`
`238`	`238`	`}`
`239`		`- pendingDynamicLink =`
`240`		`- Tasks.await(dynamicLinks.getDynamicLink(activity.get().getIntent()));`
`241`	`239`
`242`	`240`	`activity.get().getIntent().putExtra("flutterfire-used-link", true);`
	`241`	`+ pendingDynamicLink =`
	`242`	`+ Tasks.await(dynamicLinks.getDynamicLink(activity.get().getIntent()));`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`taskCompletionSource.setResult(`