Skip to content

tvOS build capability added to build_zips #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 20, 2022
Merged

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Sep 20, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Breaking ground on tvOS support.
This PR updates the cmake build system and the build_zips.py script to generate fat libs for tvOS simulators and devices.


Testing

  • Local builds: python scripts/build_scripts/build_zips.py --platform=tvos
  • Confirmed multi arch support by executing lipo -info on the resulting static libraries.
  • Confirmed the existance of symbols by running nm -S on the resulting libraries.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@DellaBitta DellaBitta marked this pull request as ready for review September 20, 2022 15:17
@DellaBitta DellaBitta added the tests-requested: quick Trigger a quick set of integration tests. label Sep 20, 2022
@DellaBitta DellaBitta added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Sep 20, 2022
@DellaBitta DellaBitta added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Sep 20, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Sep 20, 2022
@github-actions
Copy link

github-actions bot commented Sep 20, 2022

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit 02c5a73
Last updated: Tue Sep 20 20:41 PDT 2022
View integration test log & download artifacts

Failures Configs
analytics [TEST] [ERROR] [2019] [macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
database [TEST] [ERROR] [2019] [macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): ios_target]
firestore [TEST] [FAILURE] [2019] [macos] [1/6 Platform(s): windows]
functions [TEST] [ERROR] [2019] [macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
installations [TEST] [ERROR] [2019] [macos] [1/6 Platform(s): iOS] [2/3 Test Device(s): simulator_target ios_target]
messaging [TEST] [ERROR] [2019] [macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): ios_target]
[TEST] [FAILURE] [2019] [macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
storage [TEST] [ERROR] [2019] [macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): ios_target]

@DellaBitta DellaBitta merged commit 592145d into main Sep 20, 2022
@DellaBitta DellaBitta deleted the feature/tvos_build_zips branch September 20, 2022 23:55
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Sep 21, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 21, 2022
@firebase firebase locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants