-
Notifications
You must be signed in to change notification settings - Fork 46
tvOS build capability added to build_zips #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-maurice
reviewed
Sep 20, 2022
a-maurice
reviewed
Sep 20, 2022
a-maurice
approved these changes
Sep 20, 2022
❌ Integration test FAILEDRequested by @firebase-workflow-trigger[bot] on commit 02c5a73
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking ground on tvOS support.
This PR updates the cmake build system and the build_zips.py script to generate fat libs for tvOS simulators and devices.
Testing
python scripts/build_scripts/build_zips.py --platform=tvos
lipo -info
on the resulting static libraries.nm -S
on the resulting libraries.Type of Change
Place an
x
the applicable box: