Feature/build on linux #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticing errors of make crashing without any errors. Repeatedly running the build command makes it continue from the previous crash point only to crash at a later point. Some sort of thread race condition is happening as sometimes the process goes through just fine.
xbuild could be found in Unity directories or at the system level. If system level is not found, then we want to use xbuild that ships with Unity.
Using UNITY_ROOT_DIR makes the code more readable for searching files. Previously, we were using glob "*" for unity version and this was dangerous as the unity version wasn't deterministic. For example, UnityEngine.dll could come from Unity 2018 but iOS dll could come from another version. Using UNITY_ROOT_DIR makes it consistent and more cross platform.
realpath does not exist on mac. Using Python instead.
cynthiajoan
reviewed
Apr 5, 2021
cynthiajoan
approved these changes
Apr 5, 2021
a-maurice
reviewed
Apr 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to build Unity SDK on Linux and Mac.