-
Notifications
You must be signed in to change notification settings - Fork 1k
Adding global default project when running on firebase studio #8830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the Firebase CLI's integration with Firebase Studio by automatically remembering the project selected during the authentication process. By setting this project as a global default, it streamlines the user experience, ensuring that subsequent commands can operate without requiring repeated project specification, thereby reducing friction for Studio users.
Highlights
- Global Default Project Persistence: Introduced a mechanism to automatically persist the Firebase project selected during the Firebase Studio (monospace) authentication flow as the global default project. This project will be used as a fallback when no other project is explicitly specified.
- New Utility Function: Added a new utility function,
setGlobalDefaultProject
, tosrc/utils.ts
. This function handles storing the specified project ID in the user's configuration and provides informative console output to confirm the change.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new globalDefaultProject
setting to improve the user experience in Firebase Studio by making the selected project persist across commands. The implementation correctly saves the project ID to configstore
when authenticating in the Studio environment.
The changes look good and the approach is solid. I've left one suggestion to use existing logging helpers (logSuccess
, logBullet
) for a more consistent CLI output.
As you noted, this PR only implements setting the global default project. The logic to read and use this value as a fallback will be a great addition in a future change.
logger.info(`${clc.bold(project)} is now your global default project.`); | ||
logger.info("When no other project is specified (by 'firebase use' or '--project'), this project will be used."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other CLI output, consider using the existing logging helper functions like logSuccess
and logBullet
. This will provide a more familiar user experience with status indicators (e.g., checkmarks).
logSuccess
will add a ✔
prefix, and logBullet
will add an i
prefix, which is common for informational messages in this CLI.
logger.info(`${clc.bold(project)} is now your global default project.`); | |
logger.info("When no other project is specified (by 'firebase use' or '--project'), this project will be used."); | |
logSuccess(`${clc.bold(project)} is now your global default project.`); | |
logBullet("When no other project is specified (by 'firebase use' or '--project'), this project will be used."); |
Description
Adds a new setting for globalDefaultProject - when no other project is specified, this will be the fallback instead of erroring out.
This is motivated by Firebase Studio. When you use the CLI on Firebase Studio, you pick a project from the OAuth flow. Today, this project will get used for the remainder of the command (if no other project is specified) and then will be forgotten forever. This change will instead make that project the global default.
In the future, we probably want to give a way to set this via commands (and outside of Studio), but i want to float this idea out before we go further.