Skip to content

Commit 76ad222

Browse files
authored
Cleanup version messaging to include nodejs12 (#2545)
1 parent 8f13332 commit 76ad222

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

src/parseRuntimeAndValidateSDK.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,18 @@ export const RUNTIME_NOT_SET =
3636

3737
export const UNSUPPORTED_NODE_VERSION_FIREBASE_JSON_MSG = clc.bold(
3838
`functions.runtime value is unsupported. ` +
39-
`The only valid choices are: ${clc.bold("nodejs8")} and ${clc.bold("nodejs10")}.`
39+
`Valid choices are: ${clc.bold("nodejs8")}, ${clc.bold("nodejs10")}, and ${clc.bold(
40+
"nodejs12"
41+
)}.`
4042
);
4143

4244
export const UNSUPPORTED_NODE_VERSION_PACKAGE_JSON_MSG = clc.bold(
4345
`package.json in functions directory has an engines field which is unsupported. ` +
44-
`The only valid choices are: ${clc.bold('{"node": "8"}')} and ${clc.bold('{"node": "10"}')}.`
46+
`Valid choices are: ${clc.bold('{"node": "8"}')}, ${clc.bold('{"node": "10"}')}, and ${clc.bold(
47+
'{"node":"12"}'
48+
)}.`
4549
);
4650

47-
export const DEPRECATION_WARNING_MSG =
48-
clc.bold.yellow("functions: ") +
49-
"Deploying functions to Node 6 runtime, which is deprecated. Node 8 is available " +
50-
"and is the recommended runtime.";
51-
5251
export const FUNCTIONS_SDK_VERSION_TOO_OLD_WARNING =
5352
clc.bold.yellow("functions: ") +
5453
"You must have a " +

0 commit comments

Comments
 (0)