Skip to content

Commit 2ccd9d9

Browse files
authored
ng-deploy may not have configurations configured... (#6584)
* Grab the raw options, if a configuration isn't present * Accept serveTarget from ng-deploy, setting this by default in angularfire@17
1 parent 528d573 commit 2ccd9d9

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Fixed an issue preventing Angular apps using ng-deploy from being emulated or deployed. (#6584)

src/frameworks/angular/utils.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,9 @@ export async function getContext(dir: string, targetOrConfiguration?: string) {
220220
}
221221

222222
if (deployTarget) {
223-
const options = await architectHost.getOptionsForTarget(deployTarget);
223+
const options = await architectHost
224+
.getOptionsForTarget(deployTarget)
225+
.catch(() => workspaceProject.targets.get(deployTarget!.target)?.options);
224226
if (!options) throw new FirebaseError("Unable to get options for ng-deploy.");
225227
if (options.buildTarget) {
226228
assertIsString(options.buildTarget);
@@ -238,6 +240,10 @@ export async function getContext(dir: string, targetOrConfiguration?: string) {
238240
assertIsString(options.serverTarget);
239241
serverTarget = targetFromTargetString(options.serverTarget);
240242
}
243+
if (options.serveTarget) {
244+
assertIsString(options.serveTarget);
245+
serveTarget = targetFromTargetString(options.serveTarget);
246+
}
241247
if (options.serveOptimizedImages) {
242248
serveOptimizedImages = true;
243249
}

0 commit comments

Comments
 (0)