Skip to content

Commit 19a8384

Browse files
Durisvkjoehan
andauthored
Replace dependency on broken node-unzipper with native zlib (#5714)
* Replace dependency on broken node-unzipper with native zlib Fixes: #5614 #5677 firebase/firebase-tools-ui#939 firebase/firebase-tools-ui#940 * remove unused broken.zip fixture * add changelog record * fix timing out test * fix use operating system file delimiter * addressing code review comments from @joehan * better support for Windows path separators TODO: remove console logs after @christhompsongoogle tries it out. * addressing code review comments from @joehan * Add support for zip files that use signed data descriptors instead of a full entry header * Formats, fixes uneeded async/await * Remove unnecessary handling for empty files * Remove console.log --------- Co-authored-by: joehan <joehanley@google.com>
1 parent e3d1c99 commit 19a8384

File tree

32 files changed

+447
-316
lines changed

32 files changed

+447
-316
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
- Added more helpful error messages for the Firebase Hosting GitHub Action (#5749)
22
- Upgrade Firestore emulator to 1.17.4
33
- Web Frameworks will no longer try to deploy unsupported versions of NodeJS to Cloud Functions (#5733)
4+
- Fixes bug where emulators would not start correctly due to corrupted ZIP files. (#5614, #5677)
45
- Adding experimental support for deploying Flutter Web applications to Firebase Hosting (#5332)
56
- Release Emulator Suite UI v1.11.6 (#5769)
67
- Adds function emulator support for v2 firestore triggers (#5685)

0 commit comments

Comments
 (0)