Firestore document preview and basic-editing #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please kindly rebase this. |
yuchenshi
reviewed
Mar 13, 2020
Member
yuchenshi
left a comment
yuchenshi
left a comment
There was a problem hiding this comment.
LGTM in general, will take another pass and run this locally next Monday.
yuchenshi
reviewed
Mar 13, 2020
yuchenshi
requested changes
Mar 16, 2020
tstirrat
approved these changes
Mar 17, 2020
Contributor
|
This is awesome btw. So much happening here and such a concise and clear PR. Very easy to grok. I saw the number of commits and general size and thought "oh lord.. better get a beer".. but it really was super easy to follow. |
yuchenshi
approved these changes
Mar 17, 2020
tstirrat
approved these changes
Mar 17, 2020
| produce((draft, { payload }) => { | ||
| const parent = get(draft, getParentPath(payload.path)) || draft; | ||
| if (isMap(parent)) { | ||
| parent[last(payload.path) as string] = payload.value; |
Contributor
There was a problem hiding this comment.
I think last<string>() is more safe, because it will check the type of the input array, vs cast the result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking this up into smaller bits... this includes:
Note on structure, reducer function is shared between Field and Editor, but they each have their own Provided reducer instance. In effect: Field will generally exist within the whole document, while Editor will only have its state initialized to the selected Field's value.
Still to come: