firestore: minor refactor of listener registration of "versionchange" indexedb events #9087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stener to be more abstract.
🦋 Changeset detectedLatest commit: 2ff82d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Vertex AI Mock Responses Check
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
DellaBitta
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
SimpleDbclass by deleting thesetVersionChangeListener()method and replacing it with a newsetDatabaseDeletedListener()method. The new method abstracts away the details of IndexedDb events and simply lets the caller get notified of the event in which it is interested, namely, impending or past deletion of the IndexedDb database.This PR is the first step in a multi-step chain of PRs that will unify the callback for "versionchange" events with
newVersion===nulland detection of "clear site data" button being pressed in web browsers. The latter logic was added in PR #8871 but was problematic in at least one case (issue #9056). The ultimate goal is to provide an experimental setting with which affected customers can opt out of the drastic response of the Firestore SDK to "close" events on the IndexedDb database when it appears that such an event is in response to the "clear site data" button being clicked, which can result in corruption of the IndexedDb database if ignored.