Skip to content

VinF Hybrid Inference: log debug messages in conditional logic #8992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2025
Merged

VinF Hybrid Inference: log debug messages in conditional logic #8992

merged 2 commits into from
May 2, 2025

Conversation

erikeldridge
Copy link

We had some feedback today that logging would be helpful. #8991 addresses the code that feedback pertained to, but the SDK has some relatively complex conditional logic and logging would help clarify what the SDK is doing.

@erikeldridge erikeldridge requested a review from a team as a code owner May 1, 2025 23:21
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 1, 2025

⚠️ No Changeset found

Latest commit: f74a076

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v11.1

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 1, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (9968791)Merge (16f54f0)Diff
    browser46.2 kB46.7 kB+539 B (+1.2%)
    main47.4 kB47.9 kB+539 B (+1.1%)
    module46.2 kB46.7 kB+539 B (+1.2%)

  • firebase

    TypeBase (9968791)Merge (16f54f0)Diff
    firebase-vertexai.js36.3 kB36.8 kB+468 B (+1.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Zxe2HyvMe9.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 1, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • getGenerativeModel

      Size

      TypeBase (9968791)Merge (16f54f0)Diff
      size26.4 kB26.9 kB+489 B (+1.9%)
      size-with-ext-deps45.4 kB45.9 kB+495 B (+1.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/R904HSitNu.html

@erikeldridge erikeldridge force-pushed the erikeldridge-vertex-log branch from f74a076 to 78d1cc2 Compare May 2, 2025 21:22
@erikeldridge erikeldridge changed the base branch from erikeldridge-vertex-allcontents to vaihi-exp-google-ai May 2, 2025 21:22
@erikeldridge erikeldridge merged commit e859c03 into vaihi-exp-google-ai May 2, 2025
33 of 34 checks passed
@erikeldridge erikeldridge deleted the erikeldridge-vertex-log branch May 2, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikeldridge @google-oss-bot