Skip to content

VinF Hybrid Inference: set image (and text) as default input type #8984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025

Conversation

erikeldridge
Copy link

@erikeldridge erikeldridge commented Apr 29, 2025

Problem Statement

We stopped setting image as a default input type due to some confusion about the minimum support we require. We've since clarified that we're targeting v138+, which will default to multi-modal.

Solution

This change restores the logic to set image as an expected input type by default. (Text is implicitly supported.)

This change also guards against unsupported mime types, since this is a much more convenient experience than handling exceptions.

@erikeldridge erikeldridge requested a review from a team as a code owner April 29, 2025 21:51
Copy link

changeset-bot bot commented Apr 29, 2025

⚠️ No Changeset found

Latest commit: 5ee53bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v11.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 29, 2025

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (dc3794a)Merge (7f855b4)Diff
    browser45.8 kB46.2 kB+386 B (+0.8%)
    main46.9 kB47.3 kB+386 B (+0.8%)
    module45.8 kB46.2 kB+386 B (+0.8%)
  • firebase

    TypeBase (dc3794a)Merge (7f855b4)Diff
    firebase-vertexai.js35.9 kB36.3 kB+355 B (+1.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/C7y4PQU63F.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 29, 2025

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • getGenerativeModel

      Size

      TypeBase (dc3794a)Merge (7f855b4)Diff
      size26.0 kB26.4 kB+342 B (+1.3%)
      size-with-ext-deps45.0 kB45.4 kB+342 B (+0.8%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MWB7kZ9vIb.html

@gsiddh
Copy link

gsiddh commented Apr 29, 2025

LGTM.

@erikeldridge erikeldridge merged commit 31261ca into vaihi-exp-google-ai Apr 29, 2025
33 of 34 checks passed
@erikeldridge erikeldridge deleted the erikeldridge-vertex-content branch April 29, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants