Skip to content

fix(vertexai): add missing quote to chat role error message #8979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Apr 28, 2025

Add missing closing single quote to error message.

Is a changeset necessary here?

@dlarocque dlarocque requested a review from a team as a code owner April 28, 2025 16:07
Copy link

changeset-bot bot commented Apr 28, 2025

⚠️ No Changeset found

Latest commit: b490c66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (9952dbc)Merge (37dbc2f)Diff
    browser34.7 kB34.7 kB+1 B (+0.0%)
    main35.7 kB35.7 kB+1 B (+0.0%)
    module34.7 kB34.7 kB+1 B (+0.0%)
  • firebase

    TypeBase (9952dbc)Merge (37dbc2f)Diff
    firebase-vertexai.js28.3 kB28.3 kB+1 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MrvJzccxnq.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • ChatSession

      Size

      TypeBase (9952dbc)Merge (37dbc2f)Diff
      size15.8 kB15.8 kB+1 B (+0.0%)
      size-with-ext-deps34.7 kB34.7 kB+1 B (+0.0%)
    • GenerativeModel

      Size

      TypeBase (9952dbc)Merge (37dbc2f)Diff
      size18.9 kB18.9 kB+1 B (+0.0%)
      size-with-ext-deps37.9 kB37.9 kB+1 B (+0.0%)
    • getGenerativeModel

      Size

      TypeBase (9952dbc)Merge (37dbc2f)Diff
      size19.1 kB19.1 kB+1 B (+0.0%)
      size-with-ext-deps38.1 kB38.1 kB+1 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EAE2VnVPSI.html

@hsubox76
Copy link
Contributor

Add missing closing single quote to error message.

Is a changeset necessary here?

You need a changeset or the package won't publish during the release. Since we will already have a changeset for Vertex due to the Firebase AI PR, it will be fine, but if this was the only Vertex change during this release cycle, you would need it or it wouldn't publish.

@dlarocque dlarocque merged commit dd6a8f0 into main Apr 29, 2025
36 of 38 checks passed
@dlarocque dlarocque deleted the dl/add-quote branch April 29, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants