Skip to content

VinF Hybrid Inference: remove default expected input types #8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 25, 2025
Merged

VinF Hybrid Inference: remove default expected input types #8974

merged 7 commits into from
Apr 25, 2025

Conversation

erikeldridge
Copy link

@erikeldridge erikeldridge commented Apr 24, 2025 •
edited
Loading

Problem Statement

We got some feedback recommending "The SDK should probably still not hardcode the expectedInputs."

b/413399311

Proposal

So long as the image model is behind a flag, we should consider image input an advanced case and not set it as an expected input by default.

@erikeldridge erikeldridge requested a review from a team as a code owner April 24, 2025 19:07
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 52fa069

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 24, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (fafa6a8)Merge (2514ebf)Diff
    browser46.0 kB45.8 kB-182 B (-0.4%)
    main47.1 kB46.9 kB-182 B (-0.4%)
    module46.0 kB45.8 kB-182 B (-0.4%)

  • firebase

    TypeBase (fafa6a8)Merge (2514ebf)Diff
    firebase-vertexai.js36.1 kB36.0 kB-172 B (-0.5%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XVASHJKgtG.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 24, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • getGenerativeModel

      Size

      TypeBase (fafa6a8)Merge (2514ebf)Diff
      size26.2 kB26.0 kB-175 B (-0.7%)
      size-with-ext-deps45.2 kB45.0 kB-175 B (-0.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/67riGzPiLn.html

@erikeldridge erikeldridge merged commit dc3794a into vaihi-exp-google-ai Apr 25, 2025
32 of 34 checks passed
@erikeldridge erikeldridge deleted the erikeldridge-vertex-image branch April 25, 2025 22:08
@erikeldridge erikeldridge mentioned this pull request Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikeldridge @google-oss-bot