Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard earliest heartbeat once there are 30 heartbeats #8724

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Discard earliest heartbeat once there are 30 heartbeats #8724

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dc1276c
Delete earliest heartbeats only once there are 30 heartbeats
dlarocque Jan 23, 2025
2fda656
Add changeset
dlarocque Jan 23, 2025
2ae1a66
Use max heartbeat const in tests
dlarocque Jan 23, 2025
fb96954
Fix test name in all caps
dlarocque Jan 23, 2025
a261579
Fix test names
dlarocque Jan 23, 2025
1df9887
Formatting
dlarocque Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Formatting
  • Loading branch information
@dlarocque
dlarocque committed Jan 23, 2025
commit 1df988765ba1e6c49d3183a75dbf08a9c20a83e6
8 changes: 6 additions & 2 deletions packages/app/src/heartbeatService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,14 +283,18 @@ describe('HeartbeatServiceImpl', () => {
clock.tick(24 * 60 * 60 * 1000);
}

expect(heartbeatService._heartbeatsCache?.heartbeats.length).to.equal(MAX_NUM_STORED_HEARTBEATS);
expect(heartbeatService._heartbeatsCache?.heartbeats.length).to.equal(
MAX_NUM_STORED_HEARTBEATS
);
const earliestHeartbeatDate = getEarliestHeartbeatIdx(
heartbeatService._heartbeatsCache?.heartbeats!
);
const earliestHeartbeat =
heartbeatService._heartbeatsCache?.heartbeats[earliestHeartbeatDate]!;
await heartbeatService.triggerHeartbeat();
expect(heartbeatService._heartbeatsCache?.heartbeats.length).to.equal(MAX_NUM_STORED_HEARTBEATS);
expect(heartbeatService._heartbeatsCache?.heartbeats.length).to.equal(
MAX_NUM_STORED_HEARTBEATS
);
expect(
heartbeatService._heartbeatsCache?.heartbeats.indexOf(earliestHeartbeat)
).to.equal(-1);
Expand Down
Loading