Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AppCheck getToken docs text #8454

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Fix AppCheck getToken docs text #8454

merged 4 commits into from
Aug 23, 2024

Conversation

hsubox76
Copy link
Contributor

getToken() docs text inaccurately said that it returns null if no token is available. Fixed text to describe behavior accurately.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ac5fc45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review August 22, 2024 19:32
@hsubox76 hsubox76 requested review from a team as code owners August 22, 2024 19:32
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 22, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (c6a8851) and merge commit (f45161e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ebVDClUWpo.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 22, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (c6a8851) and merge commit (f45161e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/l3aQTreKbw.html

kevinthecheung
kevinthecheung approved these changes Aug 23, 2024
View reviewed changes
packages/app-check/src/api.ts Outdated Show resolved Hide resolved
hsubox76 and others added 2 commits August 23, 2024 10:58
@hsubox76 @kevinthecheung
Update packages/app-check/src/api.ts
9d1c72c 
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
@hsubox76
regenerate docs
ac5fc45
@hsubox76 hsubox76 merged commit 4ff9474 into main Aug 23, 2024
35 checks passed
@hsubox76 hsubox76 deleted the ch-appcheck-docs-fix branch August 23, 2024 20:05
dlarocque pushed a commit that referenced this pull request Sep 16, 2024
@hsubox76 @dlarocque
Fix AppCheck getToken docs text (#8454)
b166f52
@firebase firebase locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@kevinthecheung kevinthecheung kevinthecheung approved these changes

@dlarocque dlarocque dlarocque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hsubox76 @google-oss-bot @DellaBitta @kevinthecheung @dlarocque