Skip to content

Commit

Permalink
Remove modifiers from compat overloads (#8604)
Browse files Browse the repository at this point in the history
* Remove modifiers from compat overloads

* format

* Add changeset
  • Loading branch information
dlarocque authored Oct 25, 2024
1 parent 612335d commit b807119
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 1 deletion.
53 changes: 53 additions & 0 deletions .changeset/tame-paws-nail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
---
'@firebase/analytics': patch
'@firebase/analytics-compat': patch
'@firebase/analytics-interop-types': patch
'@firebase/analytics-types': patch
'@firebase/app': patch
'@firebase/app-check': patch
'@firebase/app-check-compat': patch
'@firebase/app-check-interop-types': patch
'@firebase/app-check-types': patch
'@firebase/app-compat': patch
'@firebase/app-types': patch
'@firebase/auth': patch
'@firebase/auth-compat': patch
'@firebase/auth-interop-types': patch
'@firebase/auth-types': patch
'@firebase/component': patch
'@firebase/data-connect': patch
'@firebase/database': patch
'@firebase/database-compat': patch
'@firebase/database-types': patch
'firebase': patch
'@firebase/firestore': patch
'@firebase/firestore-compat': patch
'@firebase/firestore-types': patch
'@firebase/functions': patch
'@firebase/functions-compat': patch
'@firebase/functions-types': patch
'@firebase/installations': patch
'@firebase/installations-compat': patch
'@firebase/installations-types': patch
'@firebase/logger': patch
'@firebase/messaging': patch
'@firebase/messaging-compat': patch
'@firebase/messaging-interop-types': patch
'@firebase/performance': patch
'@firebase/performance-compat': patch
'@firebase/performance-types': patch
'@firebase/remote-config': patch
'@firebase/remote-config-compat': patch
'@firebase/remote-config-types': patch
'@firebase/rules-unit-testing': patch
'@firebase/storage': patch
'@firebase/storage-compat': patch
'@firebase/storage-types': patch
'@firebase/template': patch
'@firebase/template-types': patch
'@firebase/util': patch
'@firebase/vertexai': patch
'@firebase/webchannel-wrapper': patch
---

Upgrade to TypeScript 5.5.4
2 changes: 1 addition & 1 deletion scripts/build/create-overloads.ts
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ function keepPublicFunctionsTransformer(
overloads.push(
factory.updateFunctionDeclaration(
node,
ts.getModifiers(node),
ts.canHaveDecorators(node) ? ts.getDecorators(node) : [],
node.asteriskToken,
node.name,
node.typeParameters,
Expand Down

0 comments on commit b807119

Please sign in to comment.