-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Infra] Bump swift-tools-version in Package.swift #15026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Unless we need it for some reason, keeping support for Xcode 16.2 and Swift 6.0 sounds ok to me. |
@@ -1386,7 +1405,7 @@ func googleAppMeasurementDependency() -> Package.Dependency { | |||
|
|||
// Point SPM CI to the tip of main of https://github.com/google/GoogleAppMeasurement so that the | |||
// release process can defer publishing the GoogleAppMeasurement tag until after testing. | |||
if ProcessInfo.processInfo.environment["FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT"] != nil { | |||
if Context.environment["FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT"] != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated to the Swift tools version bump. This API was added to the PackageDescription
module in Swift 5.6, and seems slightly cleaner (e.g. importing ProcessInfo is unneeded).
Draft– I want to see what CI fixes are needed.
Should we use 6.1? This would enforce Xcode 16.2+Agreed, see below commentFix #14638