-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Firebase AI] Implement new public API surface and tests #14765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Generated by 🚫 Danger |
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new public API surface for the FirebaseAI SDK, allowing developers to specify a Backend
for the AI models. The changes include the addition of a Backend
struct with options for Vertex AI and Google AI, and updates to the FirebaseAI class to utilize this new backend configuration. The tests have also been updated to reflect these changes. Overall, the changes look good and introduce a valuable feature.
Summary of Findings
- Assertion Usage: The assertions in
FirebaseAI.swift
verify that the instance is configured with the production endpoint and the correct version. While these are good for development, consider if they should be removed or modified for production code to avoid unexpected crashes. - Naming Consistency: The naming of the internal initializer
firebaseAI(app:location:apiConfig:)
inFirebaseAI.swift
is a bit confusing, as it shares the same name as the public API. Consider renaming the internal initializer to something more descriptive, likecreateFirebaseAIInstance
. - Documentation Improvements: The documentation for the
Backend
struct and its methods could be expanded to provide more clarity on when to use each backend option and the implications of choosing one over the other.
Merge Readiness
The pull request is almost ready for merging. I recommend addressing the naming consistency issue and considering the assertion usage in production code. Expanding the documentation for the Backend
struct would also be beneficial. I am unable to approve this pull request, and other reviewers should review and approve this code before merging.
Updated the FirebaseAI API surface to allow a
Backend
to be specified:#no-changelog