Skip to content

[auth-swift] AuthUserDefaultsTests.swift #11343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2023
Merged

[auth-swift] AuthUserDefaultsTests.swift #11343

merged 2 commits into from
May 27, 2023

Conversation

paulb777
Copy link
Member

  • Swift implementation of AuthUserDefault unit tests
  • Remove DataWrapper workaround

#no-changelog

@paulb777 paulb777 requested a review from ncooke3 May 26, 2023 22:46
@paulb777
Copy link
Member Author

Merging. Let's address any feedback in subsequent PRs

@paulb777 paulb777 merged commit 6d4a44f into auth-swift May 27, 2023
@paulb777 paulb777 deleted the pb-user-def-tests branch May 27, 2023 22:50
ncooke3
ncooke3 reviewed May 30, 2023
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM– no comments! Nice to see the DataWrapper can go away :)

@firebase firebase locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 left review comments

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @ncooke3 @google-oss-bot