Skip to content

FR: Return network-connection errors instead of ignoring them #5298

Open
@ghost

Description

Feature proposal

  • Firebase Component: Storage

Problem: Getting data from Storage fails silently when there is no network connection. Therefore, we can either pre-check connection (not desirable) or post-check connection if there has been silence for n seconds (not desirable).

Solution: When a request to get data is made to Storage, we should always get a response for all possible cases.

Discussion: Firebase completion handlers are generally rude in that they only report their own errors and will ignore you when there's an error outside of what it considers its purview, like network connectivity. Firebase completion handlers should be polite and let us know of all failures, regardless of blame. Therefore, I suggest appending error to include all errors or keeping error the same and additionally returning a conclusion (i.e. success, a boolean that bottom lines the task).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions