Skip to content

Commit e6d65a3

Browse files
committed
disable flaky test and add bugs to comments
1 parent 29b0f1f commit e6d65a3

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

.github/workflows/firestore.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ jobs:
105105
(github.event_name == 'pull_request' && needs.changes.outputs.changed == 'true')
106106
strategy:
107107
matrix:
108-
# TODO: Update to macos-14 which doesn't include Python 3.7
108+
# TODO(#12769): Update to macos-14 which doesn't include Python 3.7
109109
os: [macos-12, ubuntu-latest]
110110

111111
env:
@@ -153,7 +153,7 @@ jobs:
153153

154154
strategy:
155155
matrix:
156-
# TODO: Update to macos-14 which doesn't include Python 3.7
156+
# TODO(#12769): Update to macos-14 which doesn't include Python 3.7
157157
os: [macos-12]
158158
databaseId: [(default), test-db]
159159

@@ -241,7 +241,7 @@ jobs:
241241

242242
strategy:
243243
matrix:
244-
# TODO: Update to macos-14 which doesn't include Python 3.7
244+
# TODO(#12769): Update to macos-14 which doesn't include Python 3.7
245245
os: [macos-12]
246246
sanitizer: [asan, tsan]
247247

@@ -326,7 +326,7 @@ jobs:
326326
if: |
327327
(github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') ||
328328
(github.event_name == 'pull_request' && needs.changes.outputs.changed == 'true')
329-
# TODO: macOS 14 blocked on https://github.com/grpc/grpc/pull/36340
329+
# TODO(#12769): macOS 14 blocked on https://github.com/grpc/grpc/pull/36340
330330
runs-on: macos-12
331331
needs: check
332332

.github/workflows/inappmessaging.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
# Don't run on private repo unless it is a PR.
4646
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
4747

48-
# TODO: Update to macos-14 when tests are updated for Xcode 15.
48+
# TODO(#12770): Update to macos-14 when tests are updated for Xcode 15.
4949
runs-on: macos-12
5050
strategy:
5151
matrix:

.github/workflows/sessions-integration-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
if: github.repository == 'Firebase/firebase-ios-sdk'
2626
env:
2727
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
28-
#TODO: Fix macos-14 build issues
28+
#TODO(#12771): Fix macos-14 build issues
2929
runs-on: macos-12
3030
steps:
3131
- uses: actions/checkout@v4

FirebaseAuth/Tests/Unit/FIRAuthUseUserAccessGroupTests.m

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ - (void)setUp {
3737
[FIRApp resetAppForAuthUnitTests];
3838
}
3939

40-
- (void)testUseUserAccessGroup {
40+
// TODO(#12767) Fix flakiness and reenable.
41+
- (void)SKIPtestUseUserAccessGroup {
4142
id classMock = OCMClassMock([FIRAuth class]);
4243
OCMStub([classMock keychainServiceNameForAppName:OCMOCK_ANY]).andReturn(nil);
4344
FIRAuthStoredUserManager *myManager =

0 commit comments

Comments
 (0)