Skip to content

Commit b5d1882

Browse files
committed
add/remove rebasing changes
1 parent c466fc7 commit b5d1882

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

FirebaseAuth/Sources/Swift/Utilities/AuthErrorUtils.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -207,10 +207,6 @@ class AuthErrorUtils: NSObject {
207207
error(code: .invalidRecaptchaToken, message: message)
208208
}
209209

210-
static func invalidRecaptchaTokenError(message: String?) -> Error {
211-
error(code: .invalidRecaptchaToken, message: message)
212-
}
213-
214210
static func unauthorizedDomainError(message: String?) -> Error {
215211
error(code: .unauthorizedDomain, message: message)
216212
}

FirebaseAuth/Sources/Swift/Utilities/AuthRecaptchaVerifier.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
private(set) var agentConfig: AuthRecaptchaConfig?
7373
private(set) var tenantConfigs: [String: AuthRecaptchaConfig] = [:]
7474
private(set) var recaptchaClient: RCARecaptchaClientProtocol?
75-
private static var _shared: AuthRecaptchaVerifier = .init()
75+
private static var _shared = AuthRecaptchaVerifier()
7676
private let kRecaptchaVersion = "RECAPTCHA_ENTERPRISE"
7777
init() {}
7878

FirebaseAuth/Tests/Unit/PhoneAuthProviderTests.swift

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -109,14 +109,12 @@
109109
let provider = PhoneAuthProvider.provider(auth: auth)
110110
let mockVerifier = FakeAuthRecaptchaVerifier(captchaResponse: kCaptchaResponse)
111111
AuthRecaptchaVerifier.setShared(mockVerifier, auth: auth)
112-
let requestExpectation = expectation(description: "verifyRequester")
113-
rpcIssuer.rceMode = .enforce
112+
rpcIssuer.rceMode = "ENFORCE"
114113
rpcIssuer?.verifyRequester = { request in
115114
XCTAssertEqual(request.phoneNumber, self.kTestPhoneNumber)
116115
XCTAssertEqual(request.captchaResponse, self.kCaptchaResponse)
117116
XCTAssertEqual(request.recaptchaVersion, "RECAPTCHA_ENTERPRISE")
118117
XCTAssertEqual(request.codeIdentity, CodeIdentity.empty)
119-
requestExpectation.fulfill()
120118
do {
121119
try self.rpcIssuer?
122120
.respond(withJSON: [self.kVerificationIDKey: self.kTestVerificationID])
@@ -150,9 +148,9 @@
150148
.invalidRecaptchaTokenError(message: "INVALID_RECAPTCHA_TOKEN")
151149
let mockVerifier = FakeAuthRecaptchaVerifier(error: invalidRecaptchaTokenError)
152150
AuthRecaptchaVerifier.setShared(mockVerifier, auth: auth)
153-
rpcIssuer.rceMode = .enforce
151+
rpcIssuer.rceMode = "ENFORCE"
154152
do {
155-
let result = try await provider.verifyClAndSendVerificationCodeWithRecaptcha(
153+
let _ = try await provider.verifyClAndSendVerificationCodeWithRecaptcha(
156154
toPhoneNumber: kTestPhoneNumber,
157155
retryOnInvalidAppCredential: false,
158156
uiDelegate: nil,
@@ -176,9 +174,9 @@
176174
.missingRecaptchaTokenError(message: "MISSING_RECAPTCHA_TOKEN")
177175
let mockVerifier = FakeAuthRecaptchaVerifier(error: missingRecaptchaTokenError)
178176
AuthRecaptchaVerifier.setShared(mockVerifier, auth: auth)
179-
rpcIssuer.rceMode = .enforce
177+
rpcIssuer.rceMode = "ENFORCE"
180178
do {
181-
let result = try await provider.verifyClAndSendVerificationCodeWithRecaptcha(
179+
let _ = try await provider.verifyClAndSendVerificationCodeWithRecaptcha(
182180
toPhoneNumber: kTestPhoneNumber,
183181
retryOnInvalidAppCredential: false,
184182
uiDelegate: nil,

0 commit comments

Comments
 (0)