Add beforeEmailSent and beforeSmsSent trigger types #1621
+651
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te and beforeSignIn
egilmorez
approved these changes
Oct 3, 2024
src/common/providers/identity.ts
Outdated
| recaptchaActionOverride?: RecaptchaActionOptions; | ||
| } | ||
|
|
||
| /** The handler response type for beforeCreate blocking events */ |
There was a problem hiding this comment.
Let's backtick this like the above event type.
src/v2/providers/identity.ts
Outdated
|
|
||
| /** | ||
| * Handles an event that is triggered before an email is sent to a user. | ||
| * @param opts - Object containing function options |
src/v2/providers/identity.ts
Outdated
|
|
||
| /** | ||
| * Handles an event that is triggered before an SMS is sent to a user. | ||
| * @param opts - Object containing function options |
taeold
reviewed
Oct 8, 2024
src/common/providers/identity.ts
Outdated
| export type EmailType = "EMAIL_SIGN_IN" | "PASSWORD_RESET"; | ||
|
|
||
| /** | ||
| * The type of SMS message |
There was a problem hiding this comment.
Can we include the comment below to the type comment above so it shows up in the reference docs?
There was a problem hiding this comment.
With salient details about valid values in the text preferably, thanks!
egilmorez
approved these changes
Oct 9, 2024
src/common/providers/identity.ts
Outdated
| @@ -326,25 +334,50 @@ export interface Credential { | |||
| signInMethod: string; | |||
| } | |||
|
|
|||
| /** | |||
| * Possible types of emails as described by the GCIP backend, which can be: | |||
| * - An sign-in email | |||
There was a problem hiding this comment.
Just "A sign-in email". (not "An")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges changes from the beforeEmailSent (#1492) and beforeSmsSent (#1589) PRs.