Skip to content

Commit

Permalink
Don't delete fields on a non-breaking change release (#1238)
Browse files Browse the repository at this point in the history
  • Loading branch information
colerogers authored Sep 21, 2022
1 parent 65e66a2 commit b93e397
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 2 additions & 0 deletions spec/v2/providers/alerts/alerts.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,8 @@ describe('alerts', () => {

expect(converted).to.deep.eq({
...event,
alerttype: 'my-alert',
appid: 'my-app',
alertType: 'my-alert',
appId: 'my-app',
});
Expand Down
2 changes: 0 additions & 2 deletions src/v2/providers/alerts/alerts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -283,11 +283,9 @@ export function convertAlertAndApp(

if ('alerttype' in event) {
(event as any).alertType = (event as any).alerttype;
delete (event as any).alerttype;
}
if ('appid' in event) {
(event as any).appId = (event as any).appid;
delete (event as any).appid;
}

return event;
Expand Down

0 comments on commit b93e397

Please sign in to comment.