Skip to content

Commit

Permalink
Fix #136 (#141)
Browse files Browse the repository at this point in the history
* Fix #136

This commit fixes a breaking issue with the test sdk.

Exports won't function properly with functions annotated with @internal.

Which, was a little unexpected... but here we are. :)

* Update main to not export the private methods
  • Loading branch information
TheIronDev authored May 10, 2022
1 parent 948334a commit 1c79ea6
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
6 changes: 4 additions & 2 deletions spec/main.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,12 @@ import { set } from 'lodash';
import {
mockConfig,
makeChange,
_makeResourceName,
_extractParams,
wrap,
} from '../src/main';
import {
_makeResourceName,
_extractParams,
} from '../src/v1';
import { features } from '../src/features';
import { FirebaseFunctionsTest } from '../src/lifecycle';
import { alerts } from 'firebase-functions/v2';
Expand Down
1 change: 0 additions & 1 deletion src/cloudevent/generate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export function generateCombinedCloudEvent<
: generatedCloudEvent;
}

/** @internal */
export function generateMockCloudEvent<EventType extends CloudEvent<unknown>>(
cloudFunction: CloudFunction<EventType>
): EventType {
Expand Down
1 change: 0 additions & 1 deletion src/cloudevent/partials/partials.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import { pubsubOnMessagePublished } from './pubsub/pubsub-on-message-published';
import { storageV1 } from './storage';

/**
* @internal
* Note: Ordering matters. Some MockEventPartials will match more generally
* (eg {@link alertsOnAlertPublished}). In addition,
* {@link eventarcOnCustomEventPublished} acts as a catch-all.
Expand Down
2 changes: 0 additions & 2 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ export {
CallableContextOptions,
makeChange,
mockConfig,
_makeResourceName,
_extractParams,
} from './v1';

// V2 Exports
Expand Down

0 comments on commit 1c79ea6

Please sign in to comment.