Skip to content

Update readme #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 5, 2023
Merged

Update readme #84

merged 7 commits into from
May 5, 2023

Conversation

taeold
Copy link
Collaborator

@taeold taeold commented May 4, 2023

No description provided.

@taeold taeold requested review from jhuleatt and egilmorez May 4, 2023 20:17
jhuleatt
jhuleatt reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page LGTM! However, it seems like this repo is missing a CONTRIBUTING.md file. Want to add that as part of this PR?

jhuleatt
jhuleatt reviewed May 4, 2023
View reviewed changes
jhuleatt
jhuleatt reviewed May 4, 2023
View reviewed changes
@taeold taeold changed the title Update readme. Update readme May 4, 2023
cbenhagen
cbenhagen reviewed May 4, 2023
View reviewed changes
egilmorez
egilmorez reviewed May 4, 2023
View reviewed changes
Copy link
Collaborator

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things to look at, thanks!

egilmorez
egilmorez approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

Salakar
Salakar reviewed May 5, 2023
View reviewed changes
@taeold @Salakar
Fix typo.
e2a7691 
Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
@taeold taeold merged commit 777a28b into main May 5, 2023
@taeold taeold deleted the dl-readme branch May 5, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbenhagen cbenhagen cbenhagen left review comments

@jhuleatt jhuleatt jhuleatt left review comments

@Salakar Salakar Salakar left review comments

@egilmorez egilmorez egilmorez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taeold @cbenhagen @jhuleatt @Salakar @egilmorez