-
Notifications
You must be signed in to change notification settings - Fork 124
When testing on the expanded matrix, run tests on M1 Mac (via custom runner) as well. #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sunmou99 I'm still considering this a draft change because I want to make sure that the runner is stable before merging this, but could you take a look at the changes I've made in this PR and give me your comments? In particular I am wondering if it would be better to separate out architecture in the summarize script rather than the hack I've done. I'm hoping to try adding x86 integration tests soon (on linux/windows), so maybe that would be a better time to make that change. (Run on a packaged SDK is here.) |
@@ -75,6 +75,7 @@ | |||
|
|||
CAPITALIZATIONS = { | |||
"macos": "MacOS", | |||
"macosarm": "MacOS-ARM", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to have only one MacOS, and make arch as a secondary description. Some more extra work is required here for the result summary report. I'll figure it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to work in this same branch?
Description
If running tests against the expanded matrix, it will build an ARM64 version of the integration tests, and run it on an M1 Mac GitHub runner that we host ourselves.
For security purposes, this job does not use any third-party marketplace actions, nor does it pass in secrets on the command line.
The test_desktop_custom_runner step is written as generically as possible to support other custom runners we may add in the future.
Testing
Run integration-tests workflow on the expanded matrix. This works both on prebuilt SDK and from source.
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.