Skip to content

When testing on the expanded matrix, run tests on M1 Mac (via custom runner) as well. #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 66 commits into from

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Dec 20, 2021

Description

Provide details of the change, and generalize the change in the PR title above.

If running tests against the expanded matrix, it will build an ARM64 version of the integration tests, and run it on an M1 Mac GitHub runner that we host ourselves.

For security purposes, this job does not use any third-party marketplace actions, nor does it pass in secrets on the command line.

The test_desktop_custom_runner step is written as generically as possible to support other custom runners we may add in the future.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Run integration-tests workflow on the expanded matrix. This works both on prebuilt SDK and from source.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Dec 21, 2021
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Dec 22, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: failed This PR's integration tests failed. labels Dec 22, 2021
@jonsimantov jonsimantov requested a review from sunmou99 December 22, 2021 17:51
@jonsimantov
Copy link
Contributor Author

jonsimantov commented Dec 22, 2021

@sunmou99 I'm still considering this a draft change because I want to make sure that the runner is stable before merging this, but could you take a look at the changes I've made in this PR and give me your comments?

In particular I am wondering if it would be better to separate out architecture in the summarize script rather than the hack I've done. I'm hoping to try adding x86 integration tests soon (on linux/windows), so maybe that would be a better time to make that change.

(Run on a packaged SDK is here.)

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 22, 2021
@@ -75,6 +75,7 @@

CAPITALIZATIONS = {
"macos": "MacOS",
"macosarm": "MacOS-ARM",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to have only one MacOS, and make arch as a secondary description. Some more extra work is required here for the result summary report. I'll figure it out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to work in this same branch?

@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Dec 22, 2021
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: failed This PR's integration tests failed. labels Dec 22, 2021
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Dec 22, 2021
@github-actions github-actions bot removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: failed This PR's integration tests failed. labels Dec 22, 2021
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Dec 22, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 22, 2021
@jonsimantov jonsimantov closed this May 6, 2022
@firebase firebase locked and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants