Skip to content

Fix conflict for coroutines.pro file in google library. #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 19, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 19, 2023
@github-actions
Copy link

github-actions bot commented Apr 19, 2023

❌  Integration test FAILED

Requested by @jonsimantov on commit 12f442e
Last updated: Wed Apr 19 17:21 PDT 2023
View integration test log & download artifacts

Failures Configs
auth [BUILD] [ERROR] [Android] [All 3 os]
database [BUILD] [ERROR] [Android] [All 3 os]
firestore [BUILD] [ERROR] [Android] [All 3 os]
functions [BUILD] [ERROR] [Android] [All 3 os]
storage [BUILD] [ERROR] [Android] [All 3 os]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 19, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 19, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Apr 20, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 20, 2023
dconeybe pushed a commit that referenced this pull request Apr 20, 2023
Cherry-picked from #1278 to fix the "More than one file was found with OS independent path 'META-INF/com.android.tools/proguard/coroutines.pro'" error
jonsimantov added a commit that referenced this pull request Apr 20, 2023
* Fix call to AggregateQuerySnapshot constructor

* format code

* Fix "More than one file was found with OS independent path 'META-INF/com.android.tools/proguard/coroutines.pro'" error

* Revert "Fix "More than one file was found with OS independent path 'META-INF/com.android.tools/proguard/coroutines.pro'" error"

This reverts commit fc0faea.

* Fix conflict for coroutines.pro file in google library.

Cherry-picked from #1278 to fix the "More than one file was found with OS independent path 'META-INF/com.android.tools/proguard/coroutines.pro'" error

---------

Co-authored-by: Jon Simantov <jsimantov@google.com>
jonsimantov added a commit that referenced this pull request Apr 21, 2023
* Update Android dependencies - Wed Apr 19 2023

[Triggered](https://github.com/firebase/firebase-android-sdk/actions/runs/4744622642) by [firebase-android-sdk Apr 19 release](firebase/firebase-android-sdk@0451fa0).

  ### Android

- com.google.android.gms.play_services_ads → 22.0.0
- com.google.firebase.firebase_bom → 31.5.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/4744629540).

* Firestore: Fix args to AggregateQuerySnapshot constructor (#1277)

* Fix call to AggregateQuerySnapshot constructor

* Fix conflict for coroutines.pro file in google library.

Cherry-picked from #1278 to fix the "More than one file was found with OS independent path 'META-INF/com.android.tools/proguard/coroutines.pro'" error

---------

Co-authored-by: Jon Simantov <jsimantov@google.com>

* Update release notes with new versions.

---------

Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com>
Co-authored-by: Jon Simantov <jsimantov@google.com>
Co-authored-by: Denver Coneybeare <dconeybe@google.com>
AlmostMatt pushed a commit that referenced this pull request Apr 21, 2023
* Update Android dependencies - Wed Apr 19 2023

[Triggered](https://github.com/firebase/firebase-android-sdk/actions/runs/4744622642) by [firebase-android-sdk Apr 19 release](firebase/firebase-android-sdk@0451fa0).

  ### Android

- com.google.android.gms.play_services_ads → 22.0.0
- com.google.firebase.firebase_bom → 31.5.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/4744629540).

* Firestore: Fix args to AggregateQuerySnapshot constructor (#1277)

* Fix call to AggregateQuerySnapshot constructor

* Fix conflict for coroutines.pro file in google library.

Cherry-picked from #1278 to fix the "More than one file was found with OS independent path 'META-INF/com.android.tools/proguard/coroutines.pro'" error

---------

Co-authored-by: Jon Simantov <jsimantov@google.com>

* Update release notes with new versions.

---------

Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com>
Co-authored-by: Jon Simantov <jsimantov@google.com>
Co-authored-by: Denver Coneybeare <dconeybe@google.com>
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant