Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CMake target for the Messaging aar #1205

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Add a CMake target for the Messaging aar #1205

merged 2 commits into from
Feb 16, 2023

Conversation

a-maurice
Copy link
Contributor

@a-maurice a-maurice commented Feb 10, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

Add a CMake target that can be used by the Unity SDK to access the Messaging aar file, that includes the java specific code that is compiled by gradle.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Unity build that this change is for: https://github.com/firebase/firebase-unity-sdk/actions/runs/4180060512


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added skip-release-notes Skip release notes check tests-requested: quick Trigger a quick set of integration tests. labels Feb 10, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Feb 10, 2023
@github-actions
Copy link

github-actions bot commented Feb 10, 2023

Integration test with FLAKINESS (succeeded after retry)

Requested by @a-maurice on commit 399f740
Last updated: Thu Feb 16 16:15 PST 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
storage [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Feb 10, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 10, 2023
@a-maurice a-maurice merged commit 399f740 into main Feb 16, 2023
@a-maurice a-maurice deleted the am-messaging_aar branch February 16, 2023 21:51
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Feb 16, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 17, 2023
@firebase firebase locked and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants