Skip to content

Commit d85c332

Browse files
authored
Merge branch 'main' into other/java-sync
2 parents 9ea92b2 + d2776f0 commit d85c332

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

build_scripts/android/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ absbuildpath=$( pwd -P )
2727
cd "${origpath}"
2828

2929
# If NDK_ROOT is not set or is the wrong version, use to the version in /tmp.
30-
if [[ -z "${NDK_ROOT}" || ! $(grep -q "Pkg\.Revision = 21\." "${NDK_ROOT}/source.properties") ]]; then
30+
if [[ -z "${NDK_ROOT}" || -z $(grep "Pkg\.Revision = 21\." "${NDK_ROOT}/source.properties") ]]; then
3131
if [[ ! -d /tmp/android-ndk-r21e ]]; then
3232
echo "Recommended NDK version r21e not present in /tmp."
3333
echo "Please run install_prereqs.sh if you wish to use the recommended NDK version."

firestore/integration_test_internal/src/validation_test.cc

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -856,13 +856,6 @@ TEST_F(ValidationTest, QueriesWithInequalityDifferentThanFirstOrderByFail) {
856856
reason);
857857
}
858858

859-
TEST_F(ValidationTest, QueriesWithMultipleArrayContainsFiltersFail) {
860-
EXPECT_ERROR(Collection()
861-
.WhereArrayContains("foo", FieldValue::Integer(1))
862-
.WhereArrayContains("foo", FieldValue::Integer(2)),
863-
ErrorMessage(ErrorCase::kQueryMultipleArrayContains));
864-
}
865-
866859
TEST_F(ValidationTest, QueriesMustNotSpecifyStartingOrEndingPointAfterOrderBy) {
867860
CollectionReference collection = Collection();
868861
Query query = collection.OrderBy("foo");

0 commit comments

Comments
 (0)